Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2903633004: Fix AutocompleteEditTextTest (Closed)

Created:
3 years, 7 months ago by Changwan Ryu
Modified:
3 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix AutocompleteEditTextTest Since dummy input connection was used, beginBatchEdit() and endBatchEdit() was not calling TextView#onBeginBatchEdit() correctly. We can use the TextView's EditableInputConnection and expect correct results. BUG=722908 Review-Url: https://codereview.chromium.org/2903633004 Cr-Commit-Position: refs/heads/master@{#474321} Committed: https://chromium.googlesource.com/chromium/src/+/912333cc6c89529bee8dc2167c2b9602f76fda6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/android/junit/src/org/chromium/chrome/browser/omnibox/AutocompleteEditTextTest.java View 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Changwan Ryu
PTAL
3 years, 7 months ago (2017-05-24 03:57:25 UTC) #3
Ted C
lgtm
3 years, 7 months ago (2017-05-24 16:25:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903633004/1
3 years, 7 months ago (2017-05-24 16:26:38 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 16:31:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/912333cc6c89529bee8dc2167c2b...

Powered by Google App Engine
This is Rietveld 408576698