Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2903633003: Revert of Add ScopedTaskEnvironment::ExecutionControlMode. (Closed)

Created:
3 years, 7 months ago by Marijn Kruisselbrink
Modified:
3 years, 7 months ago
Reviewers:
robliao, gab, fdoray
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add ScopedTaskEnvironment::ExecutionControlMode. (patchset #6 id:100001 of https://codereview.chromium.org/2891363005/ ) Reason for revert: Is causing consistent test failures on the main waterfall in net_unittests URLRequestSimpleJobTest.CancelAfterFirstReadStarted, for example: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.9_Tests%2F41620%2F%2B%2Frecipes%2Fsteps%2Fnet_unittests%2F0%2Flogs%2FURLRequestSimpleJobTest.CancelAfterFirstReadStarted%2F0 [1130:771:0523/094643.091773:30621298248173:FATAL:scoped_task_environment.cc(178)] Check failed: !task_queue_empty_closure_. 0 net_unittests 0x0000000102d4603c base::debug::StackTrace::StackTrace(unsigned long) + 28 1 net_unittests 0x0000000102d5db70 logging::LogMessage::~LogMessage() + 224 2 net_unittests 0x000000010302df97 base::test::ScopedTaskEnvironment::RunUntilIdle() + 183 3 net_unittests 0x000000010205f824 net::URLRequestSimpleJobTest_CancelAfterFirstReadStarted_Test::TestBody() + 260 4 net_unittests 0x00000001022adf56 testing::Test::Run() + 246 5 net_unittests 0x00000001022ae9f0 testing::TestInfo::Run() + 288 6 net_unittests 0x00000001022aef57 testing::TestCase::Run() + 263 7 net_unittests 0x00000001022b5057 testing::internal::UnitTestImpl::RunAllTests() + 871 8 net_unittests 0x00000001022b4cc3 testing::UnitTest::Run() + 163 9 net_unittests 0x00000001030309b3 base::TestSuite::Run() + 163 10 net_unittests 0x000000010303e176 base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) + 134 11 net_unittests 0x0000000101fdf008 main + 440 12 libdyld.dylib 0x00007fff8d4495fd start + 1 13 ??? 0x0000000000000007 0x0 + 7 Original issue's description: > Add ScopedTaskEnvironment::ExecutionControlMode. > > This enum controls whether tasks posted within the scope of a > ScopedTaskEnvironment can run as they are posted or have to wait > until a call to RunUntilIdle() to run. > > BUG=724077 > TBR=gab@chromium.org > > Review-Url: https://codereview.chromium.org/2891363005 > Cr-Commit-Position: refs/heads/master@{#473925} > Committed: https://chromium.googlesource.com/chromium/src/+/fc7b5ec521b29a97e63a7cda5921aa5ed793679a TBR=gab@chromium.org,robliao@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=724077 Review-Url: https://codereview.chromium.org/2903633003 Cr-Commit-Position: refs/heads/master@{#473950} Committed: https://chromium.googlesource.com/chromium/src/+/92ac1582b78a62c5c3d1b49c0b1ef6088a065054

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -291 lines) Patch
M base/task_scheduler/task_scheduler_impl.h View 3 chunks +7 lines, -15 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M base/task_scheduler/task_tracker.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/task_scheduler/task_tracker.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/task_scheduler/task_tracker_posix.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/test/scoped_task_environment.h View 3 chunks +4 lines, -22 lines 0 comments Download
M base/test/scoped_task_environment.cc View 5 chunks +14 lines, -156 lines 0 comments Download
M base/test/scoped_task_environment_unittest.cc View 3 chunks +4 lines, -78 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Marijn Kruisselbrink
Created Revert of Add ScopedTaskEnvironment::ExecutionControlMode.
3 years, 7 months ago (2017-05-23 17:07:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903633003/1
3 years, 7 months ago (2017-05-23 17:07:46 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 17:08:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/92ac1582b78a62c5c3d1b49c0b1e...

Powered by Google App Engine
This is Rietveld 408576698