Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2903593002: Ensure DART_CONFIGURATION is exported and don't run code in checked mode. (Closed)

Created:
3 years, 7 months ago by ahe
Modified:
3 years, 7 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure DART_CONFIGURATION is exported and don't run code in checked mode. R=paulberry@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/9eb265439fcaa7318aea11d971f2cd3c643bfab7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M pkg/front_end/tool/fasta View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ahe
3 years, 7 months ago (2017-05-23 14:39:29 UTC) #2
Paul Berry
lgtm, thanks!
3 years, 7 months ago (2017-05-23 15:55:32 UTC) #3
scheglov
lgtm
3 years, 7 months ago (2017-05-23 16:05:58 UTC) #5
ahe
3 years, 7 months ago (2017-05-24 09:20:53 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9eb265439fcaa7318aea11d971f2cd3c643bfab7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698