Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: pkg/front_end/tool/fasta

Issue 2903593002: Ensure DART_CONFIGURATION is exported and don't run code in checked mode. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/tool/fasta
diff --git a/pkg/front_end/tool/fasta b/pkg/front_end/tool/fasta
index 4d269f33f9fd51f5805a6f07b2780415fd2f71f1..fe761fdd8647f9eb8b707d50e103f19761a71b91 100755
--- a/pkg/front_end/tool/fasta
+++ b/pkg/front_end/tool/fasta
@@ -7,8 +7,6 @@ set -e
REPO_DIR="$(git rev-parse --show-toplevel)"
-# TODO(ahe): We currently rely on the Dart VM wrapper script to define
-# DART_CONFIGURATION for locating platform.dill.
DART_VM="${REPO_DIR}/sdk/bin/dart"
TOOL_DIR="${REPO_DIR}/pkg/front_end/tool/_fasta"
@@ -20,7 +18,7 @@ function stop {
exit 1
}
-DART_CONFIGURATION=${DART_CONFIGURATION:-ReleaseX64}
+export DART_CONFIGURATION=${DART_CONFIGURATION:-ReleaseX64}
case "${1//_/-}" in
abcompile) SCRIPT="${TOOL_DIR}/abcompile.dart";;
@@ -54,7 +52,7 @@ case "${1//_/-}" in
PATCHED_SDK_DIR=$(
ls -d {xcodebuild,out}/${DART_CONFIGURATION}/patched_sdk 2>/dev/null \
| head -1)
- exec "${DART_VM}" -c -DDFE_VERBOSE=true \
+ exec "${DART_VM}" -DDFE_VERBOSE=true \
--platform=${PATCHED_SDK_DIR}/platform.dill \
--dfe="${REPO_DIR}/utils/kernel-service/kernel-service.dart" "$@"
;;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698