Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2903583005: Fix NullPointerException in SuggestionsBottomSheetContent (Closed)

Created:
3 years, 7 months ago by gaschler
Modified:
3 years, 7 months ago
Reviewers:
dgn
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix NullPointerException in SuggestionsBottomSheetContent BUG=725817 R=dgn@chromium.org Review-Url: https://codereview.chromium.org/2903583005 Cr-Commit-Position: refs/heads/master@{#474302} Committed: https://chromium.googlesource.com/chromium/src/+/6cd897e3feb8c33e7cfd003691eef6edf8265443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
gaschler
3 years, 7 months ago (2017-05-24 13:21:19 UTC) #1
dgn
lgtm
3 years, 7 months ago (2017-05-24 14:02:41 UTC) #2
dgn
On 2017/05/24 14:02:41, dgn wrote: > lgtm title nit: no nullptr in Java :p use ...
3 years, 7 months ago (2017-05-24 14:03:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903583005/1
3 years, 7 months ago (2017-05-24 14:10:55 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 15:49:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6cd897e3feb8c33e7cfd003691ee...

Powered by Google App Engine
This is Rietveld 408576698