Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2903573005:
Set up Finch feature for network time policy browser test (Closed)
DescriptionSet up Finch feature for network time policy browser test
This is a follow-up to https://codereview.chromium.org/2902603002/ where this
test was added but fails on official bots.
BUG=725232, 725847
TBR=pastarmovj@chromium.org
Review-Url: https://codereview.chromium.org/2903573005
Cr-Commit-Position: refs/heads/master@{#474354}
Committed: https://chromium.googlesource.com/chromium/src/+/0445935b1f4740e0e283c3fcd5fa7760e9d517b7
Patch Set 1 #Patch Set 2 : fix command line switches #
Total comments: 2
Messages
Total messages: 17 (12 generated)
The CQ bit was checked by estark@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by estark@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Set up Finch feature for network time policy browser test This is a follow-up to https://codereview.chromium.org/2902603002/ where this test was added but fails on official bots. BUG=725232 ========== to ========== Set up Finch feature for network time policy browser test This is a follow-up to https://codereview.chromium.org/2902603002/ where this test was added but fails on official bots. BUG=725232 TBR=pastarmovj@chromium.org ==========
estark@chromium.org changed reviewers: + pastarmovj@chromium.org, thakis@chromium.org
thakis, can you please review? (I'm TBRing the original reviewer pastarmovj for timezone convenience)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
stampy lgtm https://codereview.chromium.org/2903573005/diff/20001/chrome/browser/policy/p... File chrome/browser/policy/policy_browsertest.cc (right): https://codereview.chromium.org/2903573005/diff/20001/chrome/browser/policy/p... chrome/browser/policy/policy_browsertest.cc:4515: "<SSLNetworkTimeBrowserTestFieldTrial"); The < here is intentional, yes?
Thanks! Will land once the win_chrome_official bot is finished. https://codereview.chromium.org/2903573005/diff/20001/chrome/browser/policy/p... File chrome/browser/policy/policy_browsertest.cc (right): https://codereview.chromium.org/2903573005/diff/20001/chrome/browser/policy/p... chrome/browser/policy/policy_browsertest.cc:4515: "<SSLNetworkTimeBrowserTestFieldTrial"); On 2017/05/24 17:43:03, Nico wrote: > The < here is intentional, yes? Yeah, it's the --enable-features syntax (it's "GroupName>TrialName" or something like that.) Btw, I tested this by fix by removing the field trial from fieldtrial_testing_config.json, observing that the test as I originally wrote it failed, then observing that it passed with this SetUpCommandLine impl.
Description was changed from ========== Set up Finch feature for network time policy browser test This is a follow-up to https://codereview.chromium.org/2902603002/ where this test was added but fails on official bots. BUG=725232 TBR=pastarmovj@chromium.org ========== to ========== Set up Finch feature for network time policy browser test This is a follow-up to https://codereview.chromium.org/2902603002/ where this test was added but fails on official bots. BUG=725232,725847 TBR=pastarmovj@chromium.org ==========
The CQ bit was checked by estark@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495648853925690,
"parent_rev": "cca42bc2065bb211111f6512624b73f80aebe09d", "commit_rev":
"0445935b1f4740e0e283c3fcd5fa7760e9d517b7"}
Message was sent while issue was closed.
Description was changed from ========== Set up Finch feature for network time policy browser test This is a follow-up to https://codereview.chromium.org/2902603002/ where this test was added but fails on official bots. BUG=725232,725847 TBR=pastarmovj@chromium.org ========== to ========== Set up Finch feature for network time policy browser test This is a follow-up to https://codereview.chromium.org/2902603002/ where this test was added but fails on official bots. BUG=725232,725847 TBR=pastarmovj@chromium.org Review-Url: https://codereview.chromium.org/2903573005 Cr-Commit-Position: refs/heads/master@{#474354} Committed: https://chromium.googlesource.com/chromium/src/+/0445935b1f4740e0e283c3fcd5fa... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0445935b1f4740e0e283c3fcd5fa... |
