One BackgroundServerManager per MojoTestState

One BackgroundServerManager per MojoTestState

We cannot have a shared BackgroundServerManager across all MojoTestStates.
Currently the shared BackgroundServerManager is restarted when each child test
process connects to the parent. However when batching tests they all connect at
the start, before running the tests in sequence.

This change makes it so that MojoTestState owns a BackgroundServerManager and
creates it when the child connects. Thus allowing each test case to have its
own set of the mash services running. Without other test runs deleting them.

When a child process ends the TestState is destroyed, which will cleanup the
services.

BUG=678687
Review-Url: https://codereview.chromium.org/2903533003
Cr-Commit-Position: refs/heads/master@{#474992}
Committed: https://chromium.googlesource.com/chromium/src/+/f45dbb0e42abd0c94f144ecb6966893a17759c07

[jonross, 2017-05-25 21:18:56]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2017-05-25 21:18:57]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2017-05-25 21:18:57]

Hey,

This change moves ownership of BackgroundServiceManager to MojoTestState, for
tests not running with --single-process.

Allowing for each test being ran in parallel to have its own service manager and
according services. They are torn down when the child test case completes.

PTAL

Thanks,
Jon

[jonross, 2017-05-25 21:18:58]

Hey,

This change moves ownership of BackgroundServiceManager to MojoTestState, for
tests not running with --single-process.

Allowing for each test being ran in parallel to have its own service manager and
according services. They are torn down when the child test case completes.

PTAL

Thanks,
Jon

[sky, 2017-05-25 23:07:59]

LGTM

[jonross, 2017-05-26 02:24:25]

The CQ bit was checked by jonross@chromium.org

[jonross, 2017-05-26 02:24:26]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2903533003/#ps120001
(title: "new failure")

[commit-bot: I haz the power, 2017-05-26 02:25:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 06:11:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 06:11:35]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jonross, 2017-05-26 12:39:51]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-05-26 12:40:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 13:22:45]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495802391294400,
"parent_rev": "b2c5e5f71d6b747d62709c6f9c190c1380ce8976", "commit_rev":
"f45dbb0e42abd0c94f144ecb6966893a17759c07"}

[commit-bot: I haz the power, 2017-05-26 13:22:57]

Description was changed from

==========
One BackgroundServerManager per MojoTestState

We cannot have a shared BackgroundServerManager across all MojoTestStates.
Currently the shared BackgroundServerManager is restarted when each child test
process connects to the parent. However when batching tests they all connect at
the start, before running the tests in sequence.

This change makes it so that MojoTestState owns a BackgroundServerManager and
creates it when the child connects. Thus allowing each test case to have its
own set of the mash services running. Without other test runs deleting them.

When a child process ends the TestState is destroyed, which will cleanup the
services.

BUG=678687
==========

to

==========
One BackgroundServerManager per MojoTestState

We cannot have a shared BackgroundServerManager across all MojoTestStates.
Currently the shared BackgroundServerManager is restarted when each child test
process connects to the parent. However when batching tests they all connect at
the start, before running the tests in sequence.

This change makes it so that MojoTestState owns a BackgroundServerManager and
creates it when the child connects. Thus allowing each test case to have its
own set of the mash services running. Without other test runs deleting them.

When a child process ends the TestState is destroyed, which will cleanup the
services.

BUG=678687

Review-Url: https://codereview.chromium.org/2903533003
Cr-Commit-Position: refs/heads/master@{#474992}
Committed:
https://chromium.googlesource.com/chromium/src/+/f45dbb0e42abd0c94f144ecb6966...
==========

[commit-bot: I haz the power, 2017-05-26 13:22:58]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/f45dbb0e42abd0c94f144ecb6966...