Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2903523002: Introduce WebServiceWorkerNetworkProvider::GetProviderID() and stop static casting (Closed)

Created:
3 years, 7 months ago by horo
Modified:
3 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, mlamouri+watch-content_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, blink-reviews, darin-cc_chromium.org, kinuko+watch, tzik, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce WebServiceWorkerNetworkProvider::GetProviderID() and stop static casting BUG=725090, 443374 Review-Url: https://codereview.chromium.org/2903523002 Cr-Commit-Position: refs/heads/master@{#473881} Committed: https://chromium.googlesource.com/chromium/src/+/02fd70ff6d79411e5e5c503bd83a79453da76fb7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M content/child/service_worker/service_worker_network_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerNetworkProvider.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
horo
kinuko@ Please review this.
3 years, 7 months ago (2017-05-23 11:27:29 UTC) #4
kinuko
Well, ok. lgtm
3 years, 7 months ago (2017-05-23 13:55:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903523002/1
3 years, 7 months ago (2017-05-23 13:59:14 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 14:04:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02fd70ff6d79411e5e5c503bd83a...

Powered by Google App Engine
This is Rietveld 408576698