third_party/WebKit/Source/core/testing/Internals.idl - Issue 2903493002: NetInfo network quality extension: Add callbacks and Layout tests

Unified Diff: third_party/WebKit/Source/core/testing/Internals.idl

Issue 2903493002: NetInfo network quality extension: Add callbacks and Layout tests (Closed)

Patch Set: ps Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/LayoutTests/netinfo/network-quality.html ('K') | « third_party/WebKit/Source/core/testing/Internals.cpp ('k') | third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp » ('j') | third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/testing/Internals.idl

diff --git a/third_party/WebKit/Source/core/testing/Internals.idl b/third_party/WebKit/Source/core/testing/Internals.idl

index 5004e3ab8c68bec36236fcb2012b7e36e071eed9..d007775cafce594e26eb17153624235eaa546996 100644

--- a/third_party/WebKit/Source/core/testing/Internals.idl

+++ b/third_party/WebKit/Source/core/testing/Internals.idl

@@ -314,6 +314,7 @@

// These functions are for testing NetInfo. You must call clearNetworkConnectionInfoOverride() at the end.

[RaisesException] void setNetworkConnectionInfoOverride(boolean onLine, DOMString type, double downlinkMaxMbps);

+ [RaisesException] void setNetworkQualityInfoOverride(DOMString effective_type, unsigned long transport_rtt_msec, double downlink_throughput_mbps);

dcheng 2017/05/27 08:47:47 Out of curiosity, is it possible to use enums in t

tbansal1 2017/05/28 04:32:16 I did try, but it gave a compilation error. That

haraken 2017/05/29 01:08:14 Do you have the compile error? We should use an en

tbansal1 2017/05/29 04:45:22 When I build webkit tests, I get this: gen/blink/b

tbansal1 2017/05/29 04:53:29 Is it possible to generate the binding only for te

bashi 2017/05/29 10:43:32 Could you elaborate how you defined EffectiveConne

tbansal1 2017/05/31 04:16:02 I replied elsewhere in the CL, but this is where E

I replied elsewhere in the CL, but this is where EffectiveConnectionType is defined: https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebEf... It's also defined here (although that would probably result in an invalid dependency): https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/netinf... It seems that to be usable as an enum here, it should be defined in an .idl file. Are there any other examples of enum used here? I clicked through a few of them, but could not find any enum. Thanks.

tbansal1 2017/06/02 01:24:31 Done. Thanks for the help!!

On 2017/05/31 04:16:02, tbansal1 wrote: > On 2017/05/29 10:43:32, bashi wrote: > > On 2017/05/29 04:53:29, tbansal1 wrote: > > > On 2017/05/29 04:45:22, tbansal1 wrote: > > > > On 2017/05/29 01:08:14, haraken wrote: > > > > > On 2017/05/28 04:32:16, tbansal1 wrote: > > > > > > On 2017/05/27 08:47:47, dcheng wrote: > > > > > > > Out of curiosity, is it possible to use enums in the WebIDL for > this? > > > > > > > > > > > > I did try, but it gave a compilation error. That also explains why > > > > > > setNetworkConnectionInfoOverride() above also uses DOMString for > |type|. > > > > > > > > > > Do you have the compile error? We should use an enum here. > > > > > > > > When I build webkit tests, I get this: > > > > gen/blink/bindings/core/v8/V8Internals.cpp:4475:3: error: unknown type > name > > > > 'WebEffectiveConnectionType' > > > > WebEffectiveConnectionType* effective_type; > > > > ^ > > > > gen/blink/bindings/core/v8/V8Internals.cpp:4478:20: error: use of > undeclared > > > > identifier 'V8WebEffectiveConnectionType' > > > > effective_type = > > > > V8WebEffectiveConnectionType::toImplWithTypeCheck(info.GetIsolate(), > > info[0]); > > > > > > Is it possible to generate the binding only for tests? The binding is not > > needed > > > outside of tests. The spec requires effective connection type to be exposed > as > > a > > > string (and not enum). > > > > Could you elaborate how you defined EffectiveConnectionType and where? Using > an > > enum in internals.idl should work and `blink_tests` target should be able to > > build. > > I replied elsewhere in the CL, but this is where EffectiveConnectionType is > defined: > https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebEf... > > It's also defined here (although that would probably result in an invalid > dependency): > https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/netinf... > > > It seems that to be usable as an enum here, it should be defined in an .idl > file. Are there any other examples of enum used here? I clicked through a few of > them, but could not find any enum. Thanks.

Done. Thanks for the help!!

void clearNetworkConnectionInfoOverride();

// This function is for testing HitRegions on Canvas2D.