NetInfo network quality extension: Add callbacks and Layout tests

third_party/WebKit/Source/core/testing/Internals.idl

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 296 matching lines @@
 
     DOMString textSurroundingNode(Node node, long x, long y, unsigned long maxLength);
 
     void setFocused(boolean focused);
     void setInitialFocus(boolean reverse);
 
     boolean ignoreLayoutWithPendingStylesheets(Document document);
 
     // These functions are for testing NetInfo. You must call clearNetworkConnectionInfoOverride() at the end.
     [RaisesException] void setNetworkConnectionInfoOverride(boolean onLine, DOMString type, double downlinkMaxMbps);
+    [RaisesException] void setNetworkQualityInfoOverride(DOMString effective_type, unsigned long transport_rtt_msec, double downlink_throughput_mbps);

[dcheng, 2017/05/27 08:47:47]

Out of curiosity, is it possible to use enums in the WebIDL for this?

[tbansal1, 2017/05/28 04:32:16]

I did try, but it gave a compilation error.  That also explains why
setNetworkConnectionInfoOverride() above also uses DOMString for |type|.

[haraken, 2017/05/29 01:08:14]

Do you have the compile error? We should use an enum here.

[tbansal1, 2017/05/29 04:45:22]

When I build webkit tests, I get this:
gen/blink/bindings/core/v8/V8Internals.cpp:4475:3: error: unknown type name
'WebEffectiveConnectionType'
  WebEffectiveConnectionType* effective_type;
  ^
gen/blink/bindings/core/v8/V8Internals.cpp:4478:20: error: use of undeclared
identifier 'V8WebEffectiveConnectionType'
  effective_type =
V8WebEffectiveConnectionType::toImplWithTypeCheck(info.GetIsolate(), info[0]);

[tbansal1, 2017/05/29 04:53:29]

Is it possible to generate the binding only for tests? The binding is not needed
outside of tests. The spec requires effective connection type to be exposed as a
string (and not enum).

[bashi, 2017/05/29 10:43:32]

Could you elaborate how you defined EffectiveConnectionType and where? Using an
enum in internals.idl should work and `blink_tests` target should be able to
build.

[tbansal1, 2017/05/31 04:16:02]

I replied elsewhere in the CL, but this is where EffectiveConnectionType is
defined:
https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebEf...

It's also defined here (although that would probably result in an invalid
dependency):
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/netinf...


It seems that to be usable as an enum here, it should be defined in an .idl
file. Are there any other examples of enum used here? I clicked through a few of
them, but could not find any enum. Thanks.

[tbansal1, 2017/06/02 01:24:31]

Done. Thanks for the help!!

     void clearNetworkConnectionInfoOverride();
 
     // This function is for testing HitRegions on Canvas2D.
     unsigned long countHitRegions(CanvasRenderingContext2D context);
 
     boolean isInCanvasFontCache(Document document, DOMString fontString);
     unsigned long canvasFontCacheMaxFonts();
 
     DictionaryTest dictionaryTest();
     RecordTest recordTest();
@@ skipping 45 matching lines @@
     DOMString getProgrammaticScrollAnimationState(Node node);
 
     ClientRect visualRect(Node node);
 
     OriginTrialsTest originTrialsTest();
 
     void crash();
 
     void setIsLowEndDevice(boolean isLowEndDevice);
 };