Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2903473002: DevTools: Promisify Target domain (Closed)

Created:
3 years, 7 months ago by alph
Modified:
3 years, 7 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Promisify Target domain BUG=718063 Review-Url: https://codereview.chromium.org/2903473002 Cr-Commit-Position: refs/heads/master@{#474104} Committed: https://chromium.googlesource.com/chromium/src/+/1b02ace162351db83cec6a72c121ffb894933214

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js View 2 chunks +3 lines, -4 lines 1 comment Download
M third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 11 (5 generated)
alph
3 years, 7 months ago (2017-05-22 23:52:00 UTC) #2
alph
Pavel, could you please take a look while dgozman is ooo.
3 years, 7 months ago (2017-05-23 00:41:33 UTC) #4
pfeldman
https://codereview.chromium.org/2903473002/diff/1/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js File third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js (right): https://codereview.chromium.org/2903473002/diff/1/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js#newcode290 third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js:290: this._manager.target().targetAgent().getTargetInfo(client).then(this._onClientInfo.bind(this, clientLabelText)); You changed a random call site, but ...
3 years, 7 months ago (2017-05-23 19:10:25 UTC) #5
pfeldman
lgtm
3 years, 7 months ago (2017-05-23 21:15:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903473002/1
3 years, 7 months ago (2017-05-23 21:16:47 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 23:40:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1b02ace162351db83cec6a72c121...

Powered by Google App Engine
This is Rietveld 408576698