Add tests for DocumentMarkerListEditor::ShiftMarkersContent{D,Ind}ependent

Add tests for DocumentMarkerListEditor::ShiftMarkersContent[D/In]ependent

When we split ShiftMarkers() into ShiftMarkersContentDependent()/
ShiftMarkersContentIndependent() in https://codereview.chromium.org/2895353003,
I had to remove some test cases in InputMethodControllerTest which were testing
the (somewhat complex) ContentIndependent behavior because we don't currently
have any marker types that actually use the behavior (other than Composition
markers, which get cleared by many editing operations). So I'm adding a set of
test cases to directly test ShiftMarkersContentDependent() and
ShiftMarkersContentIndependent().

BUG=707867
Review-Url: https://codereview.chromium.org/2903413003
Cr-Commit-Position: refs/heads/master@{#475703}
Committed: https://chromium.googlesource.com/chromium/src/+/12b75fd5be227207ef7382add4c96fa41f6e40e4

[rlanday, 2017-05-26 21:21:23]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[Xiaocheng, 2017-05-26 21:33:07]

lgtm

[yosin_UTC9, 2017-05-29 04:49:53]

lgtm w/ nits

s/[D/In]ependent/{D,Ind}ependent/

In sh:
[abc] = matching one of "abc".
X{foo,bar}Y = expand into XfooY, XbarY

https://codereview.chromium.org/2903413003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h
(right):

https://codereview.chromium.org/2903413003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/markers/DocumentMarkerListEditor.h:15:
class CORE_EXPORT DocumentMarkerListEditor {
nit: s/{/final {/

[rlanday, 2017-05-30 19:17:52]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-05-30 19:17:53]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org,
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2903413003/#ps20001
(title: "Final")

[commit-bot: I haz the power, 2017-05-30 19:18:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 19:26:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 19:26:07]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[rlanday, 2017-05-30 20:52:31]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-05-30 20:52:43]

The CQ bit was unchecked by rlanday@chromium.org

[rlanday, 2017-05-30 20:52:44]

The CQ bit was checked by rlanday@chromium.org

[commit-bot: I haz the power, 2017-05-30 20:53:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 00:24:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496177564530170,
"parent_rev": "f2402377e74215e5581342abff5d77777354d066", "commit_rev":
"12b75fd5be227207ef7382add4c96fa41f6e40e4"}

[commit-bot: I haz the power, 2017-05-31 00:24:34]

Description was changed from

==========
Add tests for DocumentMarkerListEditor::ShiftMarkersContent[D/In]ependent

When we split ShiftMarkers() into ShiftMarkersContentDependent()/
ShiftMarkersContentIndependent() in https://codereview.chromium.org/2895353003,
I had to remove some test cases in InputMethodControllerTest which were testing
the (somewhat complex) ContentIndependent behavior because we don't currently
have any marker types that actually use the behavior (other than Composition
markers, which get cleared by many editing operations). So I'm adding a set of
test cases to directly test ShiftMarkersContentDependent() and
ShiftMarkersContentIndependent().

BUG=707867
==========

to

==========
Add tests for DocumentMarkerListEditor::ShiftMarkersContent[D/In]ependent

When we split ShiftMarkers() into ShiftMarkersContentDependent()/
ShiftMarkersContentIndependent() in https://codereview.chromium.org/2895353003,
I had to remove some test cases in InputMethodControllerTest which were testing
the (somewhat complex) ContentIndependent behavior because we don't currently
have any marker types that actually use the behavior (other than Composition
markers, which get cleared by many editing operations). So I'm adding a set of
test cases to directly test ShiftMarkersContentDependent() and
ShiftMarkersContentIndependent().

BUG=707867

Review-Url: https://codereview.chromium.org/2903413003
Cr-Commit-Position: refs/heads/master@{#475703}
Committed:
https://chromium.googlesource.com/chromium/src/+/12b75fd5be227207ef7382add4c9...
==========

[commit-bot: I haz the power, 2017-05-31 00:24:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/12b75fd5be227207ef7382add4c9...