Restructure type tracking in StyleValues to work better with new numeric types

third_party/WebKit/Source/core/css/CSSProperties.json5

Index: third_party/WebKit/Source/core/css/CSSProperties.json5
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.json5 b/third_party/WebKit/Source/core/css/CSSProperties.json5
index 08b7cbf6098b9bb4242f62934f94d86616ca6ccb..7225889e8528d740e7337190f3a3c0d0f78429c9 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.json5
+++ b/third_party/WebKit/Source/core/css/CSSProperties.json5
@@ -140,18 +140,26 @@
     // - separator
     // The property supports a list of values, and when there is more than one,
     // it is separated with this character.
-    // - supports_percentage
-    // The property supports percentage types.
     typedom_types: {
       default: [],
+      valid_type: "list",
+      valid_values: [
+        "Angle",
+        "Flex",
+        "Frequency",
+        "Length",
+        "Number",
+        "Percent",

[shend, 2017/05/29 23:42:08]

I like this way of handling %s.

[meade_UTC10, 2017/05/30 04:11:05]

Acknowledged.

+        "Position",
+        "Resolution",
+        "Time",
+        "Transform",
+        "Unparsed",
+        "Image"],

[shend, 2017/05/29 23:42:08]

nit: '],' on the next line.

[meade_UTC10, 2017/05/30 04:11:05]

Done.

     },
     separator: {
       valid_values: [",", " ", "/"],
     },
-    supports_percentage: {
-      default: false,
-      valid_type: "bool",
-    },
 
     // Flags which go into CSSPropertyMetadata:
     // - interpolable
@@ -716,6 +724,7 @@
       initial: "InitialBorderWidth",
       interpolable: true,
       keywords: ["thin", "medium", "thick"],
+      typedom_types: ["Length"],
       field_template: "storage_only",
       include_paths: ["platform/LayoutUnit.h"],
       type_name: "LayoutUnit",
@@ -788,6 +797,7 @@
       initial: "InitialBorderWidth",
       interpolable: true,
       keywords: ["thin", "medium", "thick"],
+      typedom_types: ["Length"],
       field_template: "storage_only",
       include_paths: ["platform/LayoutUnit.h"],
       type_name: "LayoutUnit",
@@ -820,6 +830,7 @@
       initial: "InitialBorderWidth",
       interpolable: true,
       keywords: ["thin", "medium", "thick"],
+      typedom_types: ["Length"],
       field_template: "storage_only",
       include_paths: ["platform/LayoutUnit.h"],
       type_name: "LayoutUnit",
@@ -876,7 +887,7 @@
       initial: "InitialBorderWidth",
       interpolable: true,
       keywords: ["thin", "medium", "thick"],
-      supports_percentage: true,
+      typedom_types: ["Length"],

[shend, 2017/05/29 23:42:08]

I would've though this is ["Length", "Percent"]? Does Length imply Percent?

[meade_UTC10, 2017/05/30 04:11:05]

Length does not imply percent, but as per the CL description, border-*-width
actually doesn't support percentages... the previous declaration is a mistake
>_> 

https://developer.mozilla.org/en/docs/Web/CSS/border-top-width
in devtools:
""
"5%"
""

       field_template: "storage_only",
       include_paths: ["platform/LayoutUnit.h"],
       type_name: "LayoutUnit",
@@ -890,7 +901,6 @@
       converter: "ConvertLengthOrAuto",
       interpolable: true,
       keywords: ["auto"],
-      supports_percentage: true,
       field_template: "external",
       include_paths: ["platform/Length.h"],
       type_name: "Length",
@@ -1261,7 +1271,6 @@
       is_descriptor: true,
       interpolable: true,
       keywords: ["auto", "fit-content", "min-content", "max-content"],
-      supports_percentage: true,
       field_template: "external",
       include_paths: ["platform/Length.h"],
       type_name: "Length",
@@ -1327,7 +1336,6 @@
       converter: "ConvertLengthOrAuto",
       interpolable: true,
       keywords: ["auto"],
-      supports_percentage: true,
       field_template: "external",
       include_paths: ["platform/Length.h"],
       type_name: "Length",
@@ -1788,7 +1796,6 @@
       converter: "ConvertLengthOrAuto",
       interpolable: true,
       keywords: ["auto"],
-      supports_percentage: true,
       field_template: "external",
       include_paths: ["platform/Length.h"],
       type_name: "Length",
@@ -2157,7 +2164,6 @@
       converter: "ConvertLengthOrAuto",
       interpolable: true,
       keywords: ["auto"],
-      supports_percentage: true,
       field_template: "external",
       include_paths: ["platform/Length.h"],
       type_name: "Length",
@@ -2725,7 +2731,6 @@
       is_descriptor: true,
       interpolable: true,
       keywords: ["auto", "fit-content", "min-content", "max-content"],
-      supports_percentage: true,
       field_template: "external",
       include_paths: ["platform/Length.h"],
       type_name: "Length",