Restructure type tracking in StyleValues to work better with new numeric types

third_party/WebKit/Source/core/css/CSSProperties.json5

 {
 // This file specifies all the CSS properties we support and the necessary
 // information for our code generation. The various supported arguments
 // are described below with example usage
 
   parameters: {
     // - alias_for: "other-property"
     // Properties specifying alias_for should be virtually identical to the
     // properties they alias. Minor parsing differences are allowed as long as
     // the CSSValues created are of the same format of the aliased property.
@@ skipping 122 matching lines @@
     default_value: {
     },
 
     // Flags which go into CSSOMTypes:
     // - typedom_types: ["Type", "OtherType"]
     // The property can take types specified in typedom_types for CSS Typed OM.
     // Keyword does not need to be specified as every property can take keywords.
     // - separator
     // The property supports a list of values, and when there is more than one,
     // it is separated with this character.
-    // - supports_percentage
-    // The property supports percentage types.
     typedom_types: {
       default: [],
+      valid_type: "list",
+      valid_values: [
+        "Angle",
+        "Flex",
+        "Frequency",
+        "Length",
+        "Number",
+        "Percent",

[shend, 2017/05/29 23:42:08]

I like this way of handling %s.

[meade_UTC10, 2017/05/30 04:11:05]

Acknowledged.

+        "Position",
+        "Resolution",
+        "Time",
+        "Transform",
+        "Unparsed",
+        "Image"],

[shend, 2017/05/29 23:42:08]

nit: '],' on the next line.

[meade_UTC10, 2017/05/30 04:11:05]

Done.

     },
     separator: {
       valid_values: [",", " ", "/"],
     },
-    supports_percentage: {
-      default: false,
-      valid_type: "bool",
-    },
 
     // Flags which go into CSSPropertyMetadata:
     // - interpolable
     // The interpolable flag indicates whether a property can be animated smoothly.
     // If this flag is set, the property should also be added to the switch
     // statements in AnimatedStyleBuilder, CSSPropertyEquality and
     // CSSAnimatableValueFactory.
     // - inherited
     // The property will inherit by default if no value is specified, typically
     // mentioned in specifications as "Inherited: yes"
@@ skipping 544 matching lines @@
       typedom_types: ["Image"],
       field_group: "surround",
     },
     {
       name: "border-bottom-width",
       api_class: "CSSPropertyAPIBorderWidth",
       converter: "ConvertLineWidth<float>",
       initial: "InitialBorderWidth",
       interpolable: true,
       keywords: ["thin", "medium", "thick"],
+      typedom_types: ["Length"],
       field_template: "storage_only",
       include_paths: ["platform/LayoutUnit.h"],
       type_name: "LayoutUnit",
       default_value: "LayoutUnit(3)",
       field_group: "surround",
     },
     {
       name: "border-collapse",
       independent: true,
       inherited: true,
@@ skipping 52 matching lines @@
       typedom_types: ["Image"],
       field_group: "surround",
     },
     {
       name: "border-left-width",
       api_class: "CSSPropertyAPIBorderWidth",
       converter: "ConvertLineWidth<float>",
       initial: "InitialBorderWidth",
       interpolable: true,
       keywords: ["thin", "medium", "thick"],
+      typedom_types: ["Length"],
       field_template: "storage_only",
       include_paths: ["platform/LayoutUnit.h"],
       type_name: "LayoutUnit",
       default_value: "LayoutUnit(3)",
       field_group: "surround",
     },
     {
       name: "border-right-color",
       custom_all: true,
       interpolable: true,
@@ skipping 12 matching lines @@
       keywords: ["none", "hidden", "inset", "groove", "outset", "ridge", "dotted", "dashed", "solid", "double"],
       field_group: "surround",
     },
     {
       name: "border-right-width",
       api_class: "CSSPropertyAPIBorderWidth",
       converter: "ConvertLineWidth<float>",
       initial: "InitialBorderWidth",
       interpolable: true,
       keywords: ["thin", "medium", "thick"],
+      typedom_types: ["Length"],
       field_template: "storage_only",
       include_paths: ["platform/LayoutUnit.h"],
       type_name: "LayoutUnit",
       default_value: "LayoutUnit(3)",
       field_group: "surround",
     },
     {
       name: "border-top-color",
       custom_all: true,
       interpolable: true,
@@ skipping 36 matching lines @@
       typedom_types: ["Image"],
       field_group: "surround",
     },
     {
       name: "border-top-width",
       api_class: "CSSPropertyAPIBorderWidth",
       converter: "ConvertLineWidth<float>",
       initial: "InitialBorderWidth",
       interpolable: true,
       keywords: ["thin", "medium", "thick"],
-      supports_percentage: true,
+      typedom_types: ["Length"],

[shend, 2017/05/29 23:42:08]

I would've though this is ["Length", "Percent"]? Does Length imply Percent?

[meade_UTC10, 2017/05/30 04:11:05]

Length does not imply percent, but as per the CL description, border-*-width
actually doesn't support percentages... the previous declaration is a mistake
>_> 

https://developer.mozilla.org/en/docs/Web/CSS/border-top-width
in devtools:
""
"5%"
""

       field_template: "storage_only",
       include_paths: ["platform/LayoutUnit.h"],
       type_name: "LayoutUnit",
       default_value: "LayoutUnit(3)",
       field_group: "surround",
     },
     {
       name: "bottom",
       api_class: "CSSPropertyAPIMargin",
       api_methods: ["parseSingleValue"],
       converter: "ConvertLengthOrAuto",
       interpolable: true,
       keywords: ["auto"],
-      supports_percentage: true,
       field_template: "external",
       include_paths: ["platform/Length.h"],
       type_name: "Length",
       field_group: "surround",
       default_value: "Length()",
     },
     {
       name: "box-shadow",
       converter: "ConvertShadowList",
       interpolable: true,
@@ skipping 350 matching lines @@
       custom_all: true,
       runtime_flag: "CSSGridLayout",
     },
     {
       name: "height",
       api_class: "CSSPropertyAPIWidthOrHeight",
       converter: "ConvertLengthSizing",
       is_descriptor: true,
       interpolable: true,
       keywords: ["auto", "fit-content", "min-content", "max-content"],
-      supports_percentage: true,
       field_template: "external",
       include_paths: ["platform/Length.h"],
       type_name: "Length",
       field_group: "box",
       default_value: "Length()",
     },
     {
       name: "hyphens",
       inherited: true,
       runtime_flag: "CSSHyphens",
@@ skipping 45 matching lines @@
       initial: "InitialSelfAlignment",
       runtime_flag: "CSSGridLayout",
     },
     {
       name: "left",
       api_class: "CSSPropertyAPIMargin",
       api_methods: ["parseSingleValue"],
       converter: "ConvertLengthOrAuto",
       interpolable: true,
       keywords: ["auto"],
-      supports_percentage: true,
       field_template: "external",
       include_paths: ["platform/Length.h"],
       type_name: "Length",
       field_group: "surround",
       default_value: "Length()",
     },
     {
       name: "letter-spacing",
       api_class: "CSSPropertyAPILetterAndWordSpacing",
       api_methods: ["parseSingleValue"],
@@ skipping 440 matching lines @@
       name: "resize",
       custom_value: true,
     },
     {
       name: "right",
       api_class: "CSSPropertyAPIMargin",
       api_methods: ["parseSingleValue"],
       converter: "ConvertLengthOrAuto",
       interpolable: true,
       keywords: ["auto"],
-      supports_percentage: true,
       field_template: "external",
       include_paths: ["platform/Length.h"],
       type_name: "Length",
       field_group: "surround",
       default_value: "Length()",
     },
     {
       name: "r",
       api_class: "CSSPropertyAPIStrokeOrLength",
       converter: "ConvertLength",
@@ skipping 348 matching lines @@
       field_size: 1,
       field_group: "rare-inherited",
     },
     {
       name: "top",
       api_class: "CSSPropertyAPIMargin",
       api_methods: ["parseSingleValue"],
       converter: "ConvertLengthOrAuto",
       interpolable: true,
       keywords: ["auto"],
-      supports_percentage: true,
       field_template: "external",
       include_paths: ["platform/Length.h"],
       type_name: "Length",
       field_group: "surround",
       default_value: "Length()",
     },
     {
       name: "touch-action",
       api_class: true,
       api_methods: ["parseSingleValue"],
@@ skipping 547 matching lines @@
       default_value: "2",
       field_group: "rare-inherited",
     },
     {
       name: "width",
       api_class: "CSSPropertyAPIWidthOrHeight",
       converter: "ConvertLengthSizing",
       is_descriptor: true,
       interpolable: true,
       keywords: ["auto", "fit-content", "min-content", "max-content"],
-      supports_percentage: true,
       field_template: "external",
       include_paths: ["platform/Length.h"],
       type_name: "Length",
       field_group: "box",
       default_value: "Length()"
     },
     {
       name: "will-change",
       api_class: true,
       api_methods: ["parseSingleValue"],
@@ skipping 784 matching lines @@
     {
       name: "-webkit-transition-timing-function",
       alias_for: "transition-timing-function",
     },
     {
       name: "-webkit-user-select",
       alias_for: "user-select",
     },
   ],
 }