Restructure type tracking in StyleValues to work better with new numeric types

third_party/WebKit/Source/core/css/cssom/CSSUnitValue.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CSSUnitValue_h
 #define CSSUnitValue_h
 
 #include "core/css/CSSPrimitiveValue.h"
 #include "core/css/cssom/CSSNumericValue.h"
 
 namespace blink {
 
+// Represents numeric values that can be expressed as a single number plus a
+// unit (or a naked number or percentage).
+// See CSSUnitValue.idl for more information about this class.
 class CORE_EXPORT CSSUnitValue final : public CSSNumericValue {
   WTF_MAKE_NONCOPYABLE(CSSUnitValue);
   DEFINE_WRAPPERTYPEINFO();
 
  public:
-  static CSSPrimitiveValue::UnitType UnitFromName(const String& name);
+  // The constructor defined in the IDL.
   static CSSUnitValue* Create(double value,
                               const String& unit,
                               ExceptionState&);
+  // Blink-internal ways of creating CSSUnitValues.
   static CSSUnitValue* Create(double value, CSSPrimitiveValue::UnitType);
   static CSSUnitValue* FromCSSValue(const CSSPrimitiveValue&);
 
+  // Setters and getters for attributes defined in the IDL.
   void setValue(double new_value) { value_ = new_value; }
   double value() const { return value_; }
   void setUnit(const String& new_unit, ExceptionState&);
   String unit() const;
+  String type() const;

[nainar, 2017/05/30 08:19:17]

This change sounds like it belongs in a separate CL 

[meade_UTC10, 2017/06/02 04:43:38]

Uploaded https://codereview.chromium.org/2921663004/

 
-  String cssType() const;
-
-  StyleValueType GetType() const override { return StyleValueType::kUnitType; }
-
+  // Gets the Typed OM category, e.g. length, angle, etc.
+  StyleValueType GetType() const override;
+  bool ContainsPercent() const override {
+    return unit_ == CSSPrimitiveValue::UnitType::kPercentage;
+  }
+  // Gets the representation that can be applied to an inline style.
   const CSSValue* ToCSSValue() const override;
 
  private:
+  static CSSPrimitiveValue::UnitType UnitFromName(const String& name);
+
   CSSUnitValue(double value, CSSPrimitiveValue::UnitType unit)
       : CSSNumericValue(), value_(value), unit_(unit) {}
 
   double value_;
   CSSPrimitiveValue::UnitType unit_;
 };
 
 }  // namespace blink
 
 #endif  // CSSUnitValue_h