Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2903393002:
Refactor Partition Alloc unit tests. (Closed)
|
Created:
3 years, 7 months ago by palmer Modified:
3 years, 7 months ago CC:
Mads Ager (chromium), chromium-reviews, danakj+watch_chromium.org, Dai Mikurube (NOT FULLTIME), kouhei+heap_chromium.org, oilpan-reviews, vmpstr+watch_chromium.org, wfh+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRefactor Partition Alloc unit tests.
Use testing::Test subclasses and TEST_F(...) instead of TEST(...) with
dependencies on global state.
BUG=722911
Review-Url: https://codereview.chromium.org/2903393002
Cr-Commit-Position: refs/heads/master@{#475131}
Committed: https://chromium.googlesource.com/chromium/src/+/3cc4bc0d06591e905b80959e4273666fbcc06a3f
Patch Set 1 #Patch Set 2 : Fix TSan build. #Patch Set 3 : Fix the Windows builds, too. #Messages
Total messages: 19 (10 generated)
palmer@chromium.org changed reviewers: + tsepez@chromium.org
tsepez: Any thoughts on the refactoring in general, or on the bug in particular? Thanks. :)
LGTM
lgtm
The CQ bit was checked by palmer@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by palmer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org, haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2903393002/#ps20001 (title: "Fix TSan build.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by palmer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org, haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2903393002/#ps40001 (title: "Fix the Windows builds, too.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495832445429440,
"parent_rev": "157a42ed89f0c1707620aa649fa0844b8c572bcc", "commit_rev":
"3cc4bc0d06591e905b80959e4273666fbcc06a3f"}
Message was sent while issue was closed.
Description was changed from ========== Refactor Partition Alloc unit tests. Use testing::Test subclasses and TEST_F(...) instead of TEST(...) with dependencies on global state. BUG=722911 ========== to ========== Refactor Partition Alloc unit tests. Use testing::Test subclasses and TEST_F(...) instead of TEST(...) with dependencies on global state. BUG=722911 Review-Url: https://codereview.chromium.org/2903393002 Cr-Commit-Position: refs/heads/master@{#475131} Committed: https://chromium.googlesource.com/chromium/src/+/3cc4bc0d06591e905b80959e4273... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/3cc4bc0d06591e905b80959e4273... |
