Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2903323002: fuchsia: Don't reference CurrentProcessInfo::CreationTime() (Closed)

Created:
3 years, 7 months ago by scottmg
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

fuchsia: Don't reference CurrentProcessInfo::CreationTime() (I thought maybe I could thread time and subtract it from current time, but thread time is only how long it's been scheduled for, not total wall time, so it's not really that close: https://codereview.chromium.org/2909513003/ ). BUG=706592, 726484 Review-Url: https://codereview.chromium.org/2903323002 Cr-Commit-Position: refs/heads/master@{#474846} Committed: https://chromium.googlesource.com/chromium/src/+/e911e117e1312c5d19a9e61b10e68c6b26b36832

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M base/process/process_info_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M base/trace_event/trace_log.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
scottmg
(not that many more cls to get base_unittests linking, i'll stop pestering you soon!)
3 years, 7 months ago (2017-05-25 21:33:32 UTC) #5
Lei Zhang
lgtm https://codereview.chromium.org/2903323002/diff/1/base/trace_event/trace_log.cc File base/trace_event/trace_log.cc (right): https://codereview.chromium.org/2903323002/diff/1/base/trace_event/trace_log.cc#newcode1512 base/trace_event/trace_log.cc:1512: #endif // !defined(OS_NACL) && !defined(OS_IOS) Update to match.
3 years, 7 months ago (2017-05-25 21:36:17 UTC) #8
scottmg
Thanks https://codereview.chromium.org/2903323002/diff/1/base/trace_event/trace_log.cc File base/trace_event/trace_log.cc (right): https://codereview.chromium.org/2903323002/diff/1/base/trace_event/trace_log.cc#newcode1512 base/trace_event/trace_log.cc:1512: #endif // !defined(OS_NACL) && !defined(OS_IOS) On 2017/05/25 21:36:17, ...
3 years, 7 months ago (2017-05-25 21:42:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903323002/20001
3 years, 7 months ago (2017-05-25 21:50:00 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 23:55:24 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e911e117e1312c5d19a9e61b10e6...

Powered by Google App Engine
This is Rietveld 408576698