[Android] Omnibox Placeholder Experiment

chrome/browser/about_flags.cc

Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 588d5e674fade025cf7746ffd82d82b7c337fa34..654c00108d5b667dc87528d560ed8cabf8a4dd55 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -675,6 +675,28 @@ const FeatureEntry::Choice kHerbPrototypeChoices[] = {
 };
 #endif  // OS_ANDROID
 
+#if defined(OS_ANDROID)
+const FeatureEntry::Choice kOmniboxPlaceholderExperimentChoices[] = {

[Ted C, 2017/05/30 22:14:28]

From the bug, it mentions that we don't need something in about:flags for this
but we could set a command line instead.  I think this is a bit overkill IMO for
this experiment, so I wouldn't add this unless it is really needed.

I don't see this as something a user would need to fiddle with and the testers
can just set command lines that override the finch configs (which I can help
with if needed)

[huayinz, 2017/05/30 23:10:30]

AFAIK I can only override finch config on user debug mode. I kept the flags b/c
I'm not sure if tester is testing under user debug mode or user mode.

+    {flags_ui::kGenericExperimentChoiceDefault, "", ""},
+    {flag_descriptions::kOmniboxPlaceholderExperimentSearchOrTypeUrl,
+     switches::kOmniboxPlaceholderExperimentSwitch, "SearchOrTypeUrl"},
+    {flag_descriptions::kOmniboxPlaceholderExperimentSearchOrTypeWebsiteName,
+     switches::kOmniboxPlaceholderExperimentSwitch, "SearchOrTypeWebsiteName"},
+    {flag_descriptions::kOmniboxPlaceholderExperimentSearchTheWeb,
+     switches::kOmniboxPlaceholderExperimentSwitch, "SearchTheWeb"},
+    {flag_descriptions::kOmniboxPlaceholderExperimentEnterASearchOrWebsite,
+     switches::kOmniboxPlaceholderExperimentSwitch, "EnterASearchOrWebsite"},
+    {flag_descriptions::kOmniboxPlaceholderExperimentSearchNews,
+     switches::kOmniboxPlaceholderExperimentSwitch, "SearchNews"},
+    {flag_descriptions::kOmniboxPlaceholderExperimentSearchRecipes,
+     switches::kOmniboxPlaceholderExperimentSwitch, "SearchRecipes"},
+    {flag_descriptions::kOmniboxPlaceholderExperimentSearchWeather,
+     switches::kOmniboxPlaceholderExperimentSwitch, "SearchWeather"},
+    {flag_descriptions::kOmniboxPlaceholderExperimentBlank,
+     switches::kOmniboxPlaceholderExperimentSwitch, "Blank"},
+};
+#endif  // OS_ANDROID
+
 const FeatureEntry::Choice kEnableUseZoomForDSFChoices[] = {
     {flag_descriptions::kEnableUseZoomForDsfChoiceDefault, "", ""},
     {flag_descriptions::kEnableUseZoomForDsfChoiceEnabled,
@@ -2201,6 +2223,12 @@ const FeatureEntry kFeatureEntries[] = {
      flag_descriptions::kHerbPrototypeChoicesDescription, kOsAndroid,
      MULTI_VALUE_TYPE(kHerbPrototypeChoices)},
 #endif  // OS_ANDROID
+#if defined(OS_ANDROID)
+    {"omnibox-placeholder-experiment",
+     flag_descriptions::kOmniboxPlaceholderExperimentName,
+     flag_descriptions::kOmniboxPlaceholderExperimentDescription, kOsAndroid,
+     MULTI_VALUE_TYPE(kOmniboxPlaceholderExperimentChoices)},
+#endif  // OS_ANDROID
     {"enable-md-bookmarks",
      flag_descriptions::kEnableMaterialDesignBookmarksName,
      flag_descriptions::kEnableMaterialDesignBookmarksDescription, kOsDesktop,