[Android] Omnibox Placeholder Experiment

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 657 matching lines @@
 #if defined(OS_ANDROID)
 const FeatureEntry::Choice kHerbPrototypeChoices[] = {
     {flags_ui::kGenericExperimentChoiceDefault, "", ""},
     {flags_ui::kGenericExperimentChoiceDisabled,
      switches::kTabManagementExperimentTypeDisabled, ""},
     {flag_descriptions::kHerbPrototypeFlavorElderberry,
      switches::kTabManagementExperimentTypeElderberry, ""},
 };
 #endif  // OS_ANDROID
 
+#if defined(OS_ANDROID)
+const FeatureEntry::Choice kOmniboxPlaceholderExperimentChoices[] = {

[Ted C, 2017/05/30 22:14:28]

From the bug, it mentions that we don't need something in about:flags for this
but we could set a command line instead.  I think this is a bit overkill IMO for
this experiment, so I wouldn't add this unless it is really needed.

I don't see this as something a user would need to fiddle with and the testers
can just set command lines that override the finch configs (which I can help
with if needed)

[huayinz, 2017/05/30 23:10:30]

AFAIK I can only override finch config on user debug mode. I kept the flags b/c
I'm not sure if tester is testing under user debug mode or user mode.

+    {flags_ui::kGenericExperimentChoiceDefault, "", ""},
+    {flag_descriptions::kOmniboxPlaceholderExperimentSearchOrTypeUrl,
+     switches::kOmniboxPlaceholderExperimentSwitch, "SearchOrTypeUrl"},
+    {flag_descriptions::kOmniboxPlaceholderExperimentSearchOrTypeWebsiteName,
+     switches::kOmniboxPlaceholderExperimentSwitch, "SearchOrTypeWebsiteName"},
+    {flag_descriptions::kOmniboxPlaceholderExperimentSearchTheWeb,
+     switches::kOmniboxPlaceholderExperimentSwitch, "SearchTheWeb"},
+    {flag_descriptions::kOmniboxPlaceholderExperimentEnterASearchOrWebsite,
+     switches::kOmniboxPlaceholderExperimentSwitch, "EnterASearchOrWebsite"},
+    {flag_descriptions::kOmniboxPlaceholderExperimentSearchNews,
+     switches::kOmniboxPlaceholderExperimentSwitch, "SearchNews"},
+    {flag_descriptions::kOmniboxPlaceholderExperimentSearchRecipes,
+     switches::kOmniboxPlaceholderExperimentSwitch, "SearchRecipes"},
+    {flag_descriptions::kOmniboxPlaceholderExperimentSearchWeather,
+     switches::kOmniboxPlaceholderExperimentSwitch, "SearchWeather"},
+    {flag_descriptions::kOmniboxPlaceholderExperimentBlank,
+     switches::kOmniboxPlaceholderExperimentSwitch, "Blank"},
+};
+#endif  // OS_ANDROID
+
 const FeatureEntry::Choice kEnableUseZoomForDSFChoices[] = {
     {flag_descriptions::kEnableUseZoomForDsfChoiceDefault, "", ""},
     {flag_descriptions::kEnableUseZoomForDsfChoiceEnabled,
      switches::kEnableUseZoomForDSF, "true"},
     {flag_descriptions::kEnableUseZoomForDsfChoiceDisabled,
      switches::kEnableUseZoomForDSF, "false"},
 };
 
 const FeatureEntry::Choice kEnableWebFontsInterventionV2Choices[] = {
     {flag_descriptions::kEnableWebfontsInterventionV2ChoiceDefault, "", ""},
@@ skipping 1506 matching lines @@
      ENABLE_DISABLE_VALUE_TYPE(
          autofill::switches::kEnableOfferUploadCreditCards,
          autofill::switches::kDisableOfferUploadCreditCards)},
 #endif  // TOOLKIT_VIEWS || OS_ANDROID
 #if defined(OS_ANDROID)
     {"tab-management-experiment-type",
      flag_descriptions::kHerbPrototypeChoicesName,
      flag_descriptions::kHerbPrototypeChoicesDescription, kOsAndroid,
      MULTI_VALUE_TYPE(kHerbPrototypeChoices)},
 #endif  // OS_ANDROID
+#if defined(OS_ANDROID)
+    {"omnibox-placeholder-experiment",
+     flag_descriptions::kOmniboxPlaceholderExperimentName,
+     flag_descriptions::kOmniboxPlaceholderExperimentDescription, kOsAndroid,
+     MULTI_VALUE_TYPE(kOmniboxPlaceholderExperimentChoices)},
+#endif  // OS_ANDROID
     {"enable-md-bookmarks",
      flag_descriptions::kEnableMaterialDesignBookmarksName,
      flag_descriptions::kEnableMaterialDesignBookmarksDescription, kOsDesktop,
      FEATURE_VALUE_TYPE(features::kMaterialDesignBookmarks)},
     {"enable-md-feedback", flag_descriptions::kEnableMaterialDesignFeedbackName,
      flag_descriptions::kEnableMaterialDesignFeedbackDescription, kOsDesktop,
      SINGLE_VALUE_TYPE(switches::kEnableMaterialDesignFeedback)},
     {"enable-md-incognito-ntp",
      flag_descriptions::kMaterialDesignIncognitoNTPName,
      flag_descriptions::kMaterialDesignIncognitoNTPDescription, kOsAll,
@@ skipping 1022 matching lines @@
 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags