Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Issue 2903263002: Fix LoadDataWithBaseUrlTest.testloadDataWithBaseUrlCallsOnPageStarted after r474498. (Closed)

Created:
3 years, 7 months ago by jam
Modified:
3 years, 7 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix LoadDataWithBaseUrlTest.testloadDataWithBaseUrlCallsOnPageStarted after r474498. The problem is that NavigationControllerImpl::GetEntryWithUniqueID doesn't return the pending entry; GetPendingEntry has to be checked as well. BUG=726230 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2903263002 Cr-Commit-Position: refs/heads/master@{#474758} Committed: https://chromium.googlesource.com/chromium/src/+/20e172c34b3685b8f8e6d212c866742ba729d007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M content/browser/frame_host/navigation_handle_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jam
3 years, 7 months ago (2017-05-25 16:00:48 UTC) #4
nasko
LGTM
3 years, 7 months ago (2017-05-25 17:34:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903263002/1
3 years, 7 months ago (2017-05-25 17:37:16 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 19:39:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20e172c34b3685b8f8e6d212c866...

Powered by Google App Engine
This is Rietveld 408576698