Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2903143003: Use ffmpeg_features buildflags (Closed)

Created:
3 years, 7 months ago by Paweł Hajdan Jr.
Modified:
3 years, 6 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ffmpeg_features buildflags Depends on https://chromium-review.googlesource.com/c/515103/ Also clean up older instances of system-ffmpeg-related #ifdefs (e.g. from https://codereview.chromium.org/13991013). We should probably use buildflags in the future, and keep in mind to limit system-ffmpeg-related flags. BUG=none Review-Url: https://codereview.chromium.org/2903143003 Cr-Commit-Position: refs/heads/master@{#474857} Committed: https://chromium.googlesource.com/chromium/src/+/c5989b12b1bf78c6a04303e86c498a4ae9460a81

Patch Set 1 #

Patch Set 2 : trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
M build/linux/unbundle/ffmpeg.gn View 1 3 chunks +6 lines, -6 lines 0 comments Download
M media/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/ffmpeg/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.h View 2 chunks +5 lines, -4 lines 0 comments Download
M media/filters/audio_file_reader.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Paweł Hajdan Jr.
3 years, 7 months ago (2017-05-25 10:50:35 UTC) #2
DaleCurtis
lgtm, thanks!
3 years, 6 months ago (2017-05-25 18:12:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903143003/1
3 years, 6 months ago (2017-05-25 20:24:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/303406) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-05-25 20:29:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2903143003/20001
3 years, 6 months ago (2017-05-25 20:49:06 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 01:00:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c5989b12b1bf78c6a04303e86c49...

Powered by Google App Engine
This is Rietveld 408576698