Track printer protocol usage for CUPS printers.

Track printer protocol usage for CUPS printers.

Add a metric called CUPS.PrinterProtocol that records the protocol for
a selected printer. This will be used to track usage of the various
protocols to prioritize effort.

BUG=726103
Review-Url: https://codereview.chromium.org/2903113002
Cr-Commit-Position: refs/heads/master@{#474859}
Committed: https://chromium.googlesource.com/chromium/src/+/d86afbe21be3199f9a0674b2d68ac58d1e1737c6

[skau, 2017-05-24 21:51:00]

skau@chromium.org changed reviewers:
+ justincarlson@chromium.org, jwd@chromium.org

[skau, 2017-05-24 21:51:00]

jwd@: please review the new metrics
justincarlson@: everything

[Carlson, 2017-05-25 16:24:35]

lgtm

https://codereview.chromium.org/2903113002/diff/1/chrome/browser/ui/webui/pri...
File chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc
(right):

https://codereview.chromium.org/2903113002/diff/1/chrome/browser/ui/webui/pri...
chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc:129:
chromeos::Printer::PROTOCOL_MAX);
Should we be leaving space in the enum for possible future values?

[skau, 2017-05-25 18:49:54]

skau@chromium.org changed reviewers:
+ thestig@chromium.org

[skau, 2017-05-25 18:49:55]

Per a comment in a related CL, I updated the namespace of the metric to
Printing.CUPS.*

thestig@: print_preview/* OWNERS

https://codereview.chromium.org/2903113002/diff/1/chrome/browser/ui/webui/pri...
File chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc
(right):

https://codereview.chromium.org/2903113002/diff/1/chrome/browser/ui/webui/pri...
chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc:129:
chromeos::Printer::PROTOCOL_MAX);
On 2017/05/25 16:24:35, Carlson wrote:
> Should we be leaving space in the enum for possible future values?

No.  The max value is just to help in constructing the buckets locally.  We'll
just add values above PROTOCOL_MAX and it'll increment automatically.

[Lei Zhang, 2017-05-25 19:02:29]

lgtm

https://codereview.chromium.org/2903113002/diff/20001/chromeos/printing/print...
File chromeos/printing/printer_configuration.h (right):

https://codereview.chromium.org/2903113002/diff/20001/chromeos/printing/print...
chromeos/printing/printer_configuration.h:53: UNKOWN = 0,
Typo

https://codereview.chromium.org/2903113002/diff/20001/chromeos/printing/print...
chromeos/printing/printer_configuration.h:53: UNKOWN = 0,
Can we start using kFoo?
https://bugs.chromium.org/p/chromium/issues/detail?id=711332

[skau, 2017-05-25 19:35:49]

Thanks for the review.  Enums are fixed.  I'm now subscribed to cxx.

https://codereview.chromium.org/2903113002/diff/20001/chromeos/printing/print...
File chromeos/printing/printer_configuration.h (right):

https://codereview.chromium.org/2903113002/diff/20001/chromeos/printing/print...
chromeos/printing/printer_configuration.h:53: UNKOWN = 0,
On 2017/05/25 19:02:29, Lei Zhang wrote:
> Can we start using kFoo?
> https://bugs.chromium.org/p/chromium/issues/detail?id=711332

Done.

https://codereview.chromium.org/2903113002/diff/20001/chromeos/printing/print...
chromeos/printing/printer_configuration.h:53: UNKOWN = 0,
On 2017/05/25 19:02:29, Lei Zhang wrote:
> Typo

Done.

[jwd, 2017-05-25 19:55:03]

lgtm

[skau, 2017-05-25 22:51:17]

The CQ bit was checked by skau@chromium.org

[skau, 2017-05-25 22:51:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
justincarlson@chromium.org, thestig@chromium.org, jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2903113002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-25 22:52:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 01:04:08]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495752677627240,
"parent_rev": "96bd408ae32e5925624d5f4359687df707205de3", "commit_rev":
"d86afbe21be3199f9a0674b2d68ac58d1e1737c6"}

[commit-bot: I haz the power, 2017-05-26 01:04:21]

Description was changed from

==========
Track printer protocol usage for CUPS printers.

Add a metric called CUPS.PrinterProtocol that records the protocol for
a selected printer. This will be used to track usage of the various
protocols to prioritize effort.

BUG=726103
==========

to

==========
Track printer protocol usage for CUPS printers.

Add a metric called CUPS.PrinterProtocol that records the protocol for
a selected printer. This will be used to track usage of the various
protocols to prioritize effort.

BUG=726103

Review-Url: https://codereview.chromium.org/2903113002
Cr-Commit-Position: refs/heads/master@{#474859}
Committed:
https://chromium.googlesource.com/chromium/src/+/d86afbe21be3199f9a0674b2d68a...
==========

[commit-bot: I haz the power, 2017-05-26 01:04:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d86afbe21be3199f9a0674b2d68a...