WebUI: Linting: Add missing semicolons in local_ntp code.

WebUI: Linting: Add missing semicolons in local_ntp code.

This is in preparation of enabling http://eslint.org/docs/rules/semi check
during PRESUBMIT, which will enforce the following section from the styleguide:
https://google.github.io/styleguide/jsguide.html#formatting-semicolons-are-required

BUG=720034
TBR=treib@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2903063007
Cr-Commit-Position: refs/heads/master@{#475625}
Committed: https://chromium.googlesource.com/chromium/src/+/248b8502849c81f656d4ae7c7a8329a948108fb1

[dpapad, 2017-05-25 21:18:12]

Description was changed from

==========
WebUI: Add missing semicolons in local_ntp code.

This is in preparation of enabling http://eslint.org/docs/rules/semi check
during PRESUBMIT, which will enforce the following section from the styleguide:
https://google.github.io/styleguide/jsguide.html#formatting-semicolons-are-re...

BUG=720034
==========

to

==========
WebUI: Add missing semicolons in local_ntp code.

This is in preparation of enabling http://eslint.org/docs/rules/semi check
during PRESUBMIT, which will enforce the following section from the styleguide:
https://google.github.io/styleguide/jsguide.html#formatting-semicolons-are-re...

BUG=720034
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-05-25 21:22:15]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 21:22:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-05-25 21:28:42]

dpapad@chromium.org changed reviewers:
+ treib@chromium.org

[dpapad, 2017-05-25 21:28:43]

https://codereview.chromium.org/2903063007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/local_ntp/local_ntp.js (right):

https://codereview.chromium.org/2903063007/diff/20001/chrome/browser/resource...
chrome/browser/resources/local_ntp/local_ntp.js:9: // sha256sum local_ntp.js |
cut -d " " -f 1 | xxd -r -p | base64
It is unfortunate that modifying this file is now much more cumbersome. Could
this not be done dynamically?

Regardless of the above, it took quite a bit of effort to figure out how to
calculate the hash. Let me know if there is an easier way.

[dpapad, 2017-05-25 21:35:19]

Description was changed from

==========
WebUI: Add missing semicolons in local_ntp code.

This is in preparation of enabling http://eslint.org/docs/rules/semi check
during PRESUBMIT, which will enforce the following section from the styleguide:
https://google.github.io/styleguide/jsguide.html#formatting-semicolons-are-re...

BUG=720034
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: Linting: Add missing semicolons in local_ntp code.

This is in preparation of enabling http://eslint.org/docs/rules/semi check
during PRESUBMIT, which will enforce the following section from the styleguide:
https://google.github.io/styleguide/jsguide.html#formatting-semicolons-are-re...

BUG=720034
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-05-26 01:45:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 01:45:03]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dpapad, 2017-05-30 16:53:34]

On 2017/05/25 at 21:28:43, dpapad wrote:
>
https://codereview.chromium.org/2903063007/diff/20001/chrome/browser/resource...
> File chrome/browser/resources/local_ntp/local_ntp.js (right):
> 
>
https://codereview.chromium.org/2903063007/diff/20001/chrome/browser/resource...
> chrome/browser/resources/local_ntp/local_ntp.js:9: // sha256sum local_ntp.js |
cut -d " " -f 1 | xxd -r -p | base64
> It is unfortunate that modifying this file is now much more cumbersome. Could
this not be done dynamically?
> 
> Regardless of the above, it took quite a bit of effort to figure out how to
calculate the hash. Let me know if there is an easier way.

Friendly ping.

[dpapad, 2017-05-30 17:00:49]

Description was changed from

==========
WebUI: Linting: Add missing semicolons in local_ntp code.

This is in preparation of enabling http://eslint.org/docs/rules/semi check
during PRESUBMIT, which will enforce the following section from the styleguide:
https://google.github.io/styleguide/jsguide.html#formatting-semicolons-are-re...

BUG=720034
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: Linting: Add missing semicolons in local_ntp code.

This is in preparation of enabling http://eslint.org/docs/rules/semi check
during PRESUBMIT, which will enforce the following section from the styleguide:
https://google.github.io/styleguide/jsguide.html#formatting-semicolons-are-re...

BUG=720034
TBR=treib@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-05-30 17:00:49]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org
- treib@chromium.org

[dpapad, 2017-05-30 17:01:10]

On 2017/05/30 at 16:53:34, dpapad wrote:
> On 2017/05/25 at 21:28:43, dpapad wrote:
> >
https://codereview.chromium.org/2903063007/diff/20001/chrome/browser/resource...
> > File chrome/browser/resources/local_ntp/local_ntp.js (right):
> > 
> >
https://codereview.chromium.org/2903063007/diff/20001/chrome/browser/resource...
> > chrome/browser/resources/local_ntp/local_ntp.js:9: // sha256sum local_ntp.js
| cut -d " " -f 1 | xxd -r -p | base64
> > It is unfortunate that modifying this file is now much more cumbersome.
Could this not be done dynamically?
> > 
> > Regardless of the above, it took quite a bit of effort to figure out how to
calculate the hash. Let me know if there is an easier way.
> 
> Friendly ping.

@treib is OOO according to their calendar. Redirecting.

[Dan Beam, 2017-05-30 17:12:23]

lgtm

[dpapad, 2017-05-30 17:28:08]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-05-30 17:28:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 19:16:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496165288343690,
"parent_rev": "bc06b2e2dbd546ff00c8d7626fb915d86136aede", "commit_rev":
"248b8502849c81f656d4ae7c7a8329a948108fb1"}

[commit-bot: I haz the power, 2017-05-30 19:17:16]

Description was changed from

==========
WebUI: Linting: Add missing semicolons in local_ntp code.

This is in preparation of enabling http://eslint.org/docs/rules/semi check
during PRESUBMIT, which will enforce the following section from the styleguide:
https://google.github.io/styleguide/jsguide.html#formatting-semicolons-are-re...

BUG=720034
TBR=treib@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
WebUI: Linting: Add missing semicolons in local_ntp code.

This is in preparation of enabling http://eslint.org/docs/rules/semi check
during PRESUBMIT, which will enforce the following section from the styleguide:
https://google.github.io/styleguide/jsguide.html#formatting-semicolons-are-re...

BUG=720034
TBR=treib@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2903063007
Cr-Commit-Position: refs/heads/master@{#475625}
Committed:
https://chromium.googlesource.com/chromium/src/+/248b8502849c81f656d4ae7c7a83...
==========

[commit-bot: I haz the power, 2017-05-30 19:17:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/248b8502849c81f656d4ae7c7a83...

[Marc Treib, 2017-06-07 08:49:33]

treib@chromium.org changed reviewers:
+ treib@chromium.org

[Marc Treib, 2017-06-07 08:49:34]

lgtm

Thanks! Sorry for the delay, I was OOO and just got back.

https://codereview.chromium.org/2903063007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/local_ntp/local_ntp.js (right):

https://codereview.chromium.org/2903063007/diff/20001/chrome/browser/resource...
chrome/browser/resources/local_ntp/local_ntp.js:9: // sha256sum local_ntp.js |
cut -d " " -f 1 | xxd -r -p | base64
On 2017/05/25 21:28:43, dpapad wrote:
> It is unfortunate that modifying this file is now much more cumbersome. Could
> this not be done dynamically?
> 
> Regardless of the above, it took quite a bit of effort to figure out how to
> calculate the hash. Let me know if there is an easier way.

If there's a mismatch, you should get an error message in the console that tells
you the expected ID.
Automatically integrating this in the build process would sure be nice, but I
don't know of any good (low-overhead) way to do this. Ideas welcome!