Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2902943004:
Update the V8 version for Chromium branch 60. (Closed)
|
Created:
3 years, 7 months ago by vogelheim Modified:
3 years, 7 months ago Reviewers:
Michael Achenbach CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate the V8 version for Chromium branch 60.
This is a roll-back to 6.0.286. This is the most stable candidate out
of the latest Canaries.
If this commit results in failures in Blink please contact the Blink sheriff.
They may need to make changes to Blnik because of the roll-back.
When in doubt please try to contact the committer and reviewers of this CL
before reverting it.
TBR=machenbach@chromium.org
Review-Url: https://codereview.chromium.org/2902943004
Cr-Commit-Position: refs/heads/master@{#474293}
Committed: https://chromium.googlesource.com/chromium/src/+/44d0d64eb010c6d52b53359aa37d338ea8a9d3b8
Patch Set 1 #Patch Set 2 : Rebase. #Patch Set 3 : Use cherry-picked version. #Messages
Total messages: 24 (17 generated)
The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
lgtm
Please rebase to 789ec38b623c0fa9a57bc598b5447a8e859b4790
The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/2902943004/#ps40001 (title: "Use cherry-picked version.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
haha, is Blnik part of the template where you copied the cl desc from?
On 2017/05/24 14:43:52, machenbach (OOO) wrote: > haha, is Blnik part of the template where you copied the cl desc from? Yes. :-/
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495636965173490,
"parent_rev": "973bb243e5b37af1b8f8b34f44f2643a1aca7e3e", "commit_rev":
"44d0d64eb010c6d52b53359aa37d338ea8a9d3b8"}
Message was sent while issue was closed.
Description was changed from ========== Update the V8 version for Chromium branch 60. This is a roll-back to 6.0.286. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blnik because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org ========== to ========== Update the V8 version for Chromium branch 60. This is a roll-back to 6.0.286. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blnik because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2902943004 Cr-Commit-Position: refs/heads/master@{#474293} Committed: https://chromium.googlesource.com/chromium/src/+/44d0d64eb010c6d52b53359aa37d... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/44d0d64eb010c6d52b53359aa37d... |
