Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2902943003: Update status for passing analyzer test. (Closed)

Created:
3 years, 7 months ago by Bill Hesse
Modified:
3 years, 7 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update status for passing analyzer test. This test started passing with 1cfb242321655fa34ecc1a28525aaada8dcc2650 https://codereview.chromium.org/2901853002 Also removed comments in status file, and placed issue number comments on the test status lines. BUG=dartbug.com/14879 R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/2a0dd9d43c60a118d435b5befc7e52876b80774c

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -112 lines) Patch
M tests/language/language_analyzer2.status View 6 chunks +53 lines, -112 lines 3 comments Download

Messages

Total messages: 6 (2 generated)
Bill Hesse
https://codereview.chromium.org/2902943003/diff/1/tests/language/language_analyzer2.status File tests/language/language_analyzer2.status (left): https://codereview.chromium.org/2902943003/diff/1/tests/language/language_analyzer2.status#oldcode61 tests/language/language_analyzer2.status:61: ref_before_declaration_test/none: fail # test issue 14879, "P" is not ...
3 years, 7 months ago (2017-05-24 11:35:40 UTC) #2
ahe
lgtm https://codereview.chromium.org/2902943003/diff/1/tests/language/language_analyzer2.status File tests/language/language_analyzer2.status (right): https://codereview.chromium.org/2902943003/diff/1/tests/language/language_analyzer2.status#newcode378 tests/language/language_analyzer2.status:378: issue13474_test: StaticWarning, OK # Issue Issue number missing.
3 years, 7 months ago (2017-05-24 11:40:12 UTC) #3
Bill Hesse
Committed patchset #1 (id:1) manually as 2a0dd9d43c60a118d435b5befc7e52876b80774c (presubmit successful).
3 years, 7 months ago (2017-05-24 11:52:47 UTC) #5
Bill Hesse
3 years, 7 months ago (2017-05-24 11:53:28 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2902943003/diff/1/tests/language/language_ana...
File tests/language/language_analyzer2.status (right):

https://codereview.chromium.org/2902943003/diff/1/tests/language/language_ana...
tests/language/language_analyzer2.status:378: issue13474_test: StaticWarning, OK
# Issue
On 2017/05/24 11:40:12, ahe wrote:
> Issue number missing.

I guess it is issue 13474.  Done.

Powered by Google App Engine
This is Rietveld 408576698