Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2902903002: Fix missing distribution recalc in quirks mode and Shadow DOM v0. (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
hayato
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing distribution recalc in quirks mode and Shadow DOM v0. If a shadow tree had the following CONTENT element, and a class attribute of an element was changed to class="&#x212a;", distribution recalc was not triggered because selector matching in quirks mode is done with ASCII-lower strings, but Element::ShouldInvalidateDistributionWhenAttributeChanged() incorrectly applied Unicode fold-case. <content select=".&#x212a;"> This CL is a behavior change, but this doesn't add a new test because Shadow DOM v0 will be removed, and Shadow DOM in quirks mode must be very rare. BUG=627682 Review-Url: https://codereview.chromium.org/2902903002 Cr-Commit-Position: refs/heads/master@{#474209} Committed: https://chromium.googlesource.com/chromium/src/+/e4c18f4225d4a580bd6506687f9e39e42a79d32d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
tkent
hayato@, would you review this please?
3 years, 7 months ago (2017-05-24 05:29:15 UTC) #4
hayato
lgtm
3 years, 7 months ago (2017-05-24 05:41:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902903002/1
3 years, 7 months ago (2017-05-24 08:04:40 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 08:08:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e4c18f4225d4a580bd6506687f9e...

Powered by Google App Engine
This is Rietveld 408576698