Issue 2902813005: remove fasta <--> analyzer token translation

Issue 2902813005: remove fasta <--> analyzer token translation (Closed)

Created:
3 years, 7 months ago by danrubel

Modified:
3 years, 7 months ago

Reviewers:
ahe, scheglov

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

remove fasta <--> analyzer token translation R=ahe@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/136698a73481394ed4ad5a82a7ba4f88bdd0dd6e

Patch Set 1 #

Total comments: 2

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+194 lines, -886 lines)			Patch
M	pkg/analyzer/lib/src/fasta/ast_builder.dart	View	72 chunks	+172 lines, -256 lines	0 comments	Download
M	pkg/analyzer/lib/src/fasta/token_utils.dart	View	2 chunks	+16 lines, -581 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_fasta_test.dart	View	4 chunks	+5 lines, -6 lines	0 comments	Download
M	pkg/front_end/test/scanner_fasta_test.dart	View	2 chunks	+0 lines, -16 lines	0 comments	Download
M	pkg/front_end/test/scanner_roundtrip_test.dart	View	1 chunk	+1 line, -27 lines	2 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ahe

lgtm \o/ https://codereview.chromium.org/2902813005/diff/1/pkg/front_end/test/scanner_roundtrip_test.dart File pkg/front_end/test/scanner_roundtrip_test.dart (right): https://codereview.chromium.org/2902813005/diff/1/pkg/front_end/test/scanner_roundtrip_test.dart#newcode17 pkg/front_end/test/scanner_roundtrip_test.dart:17: // round trip test removed Shouldn't you ...

3 years, 7 months ago (2017-05-24 21:32:00 UTC) #5

danrubel

Committed patchset #1 (id:1) manually as 136698a73481394ed4ad5a82a7ba4f88bdd0dd6e (presubmit successful).

3 years, 7 months ago (2017-05-24 21:34:17 UTC) #7

danrubel

3 years, 7 months ago (2017-05-25 01:08:15 UTC) #8

Message was sent while issue was closed.

https://codereview.chromium.org/2902813005/diff/1/pkg/front_end/test/scanner_...
File pkg/front_end/test/scanner_roundtrip_test.dart (right):

https://codereview.chromium.org/2902813005/diff/1/pkg/front_end/test/scanner_...
pkg/front_end/test/scanner_roundtrip_test.dart:17: // round trip test removed
On 2017/05/24 21:32:00, ahe wrote:
> Shouldn't you just delete this file?

Good point. Done.
https://codereview.chromium.org/2900303003/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages