Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1404)

Unified Diff: pkg/front_end/test/scanner_roundtrip_test.dart

Issue 2902813005: remove fasta <--> analyzer token translation (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/test/scanner_fasta_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/test/scanner_roundtrip_test.dart
diff --git a/pkg/front_end/test/scanner_roundtrip_test.dart b/pkg/front_end/test/scanner_roundtrip_test.dart
index 452fdc7e37f7059d77d249e4382c1a9ff46481bc..f8d3bce9edd2b048030b6e035e122040f6190f10 100644
--- a/pkg/front_end/test/scanner_roundtrip_test.dart
+++ b/pkg/front_end/test/scanner_roundtrip_test.dart
@@ -14,33 +14,7 @@ import 'scanner_fasta_test.dart';
import 'scanner_test.dart';
main() {
- defineReflectiveSuite(() {
- defineReflectiveTests(ScannerTest_RoundTrip);
- });
-}
-
-/// Scanner tests that use the analyzer scanner, then convert the resulting
-/// token stream into a Fasta token stream, then convert back to an analyzer
-/// token stream before verifying assertions.
-///
-/// These tests help to validate the correctness of the analyzer->Fasta token
-/// stream conversion.
-@reflectiveTest
-class ScannerTest_RoundTrip extends ScannerTest {
- @override
- Token scanWithListener(String source, ErrorListener listener,
- {bool genericMethodComments: false,
- bool lazyAssignmentOperators: false}) {
- var analyzerToken = super.scanWithListener(source, listener,
- genericMethodComments: genericMethodComments,
- lazyAssignmentOperators: lazyAssignmentOperators);
- var fastaToken = fromAnalyzerTokenStream(analyzerToken);
- // Since [scanWithListener] reports errors to the listener, we don't
- // expect any error tokens in the Fasta token stream, so we convert using
- // ToAnalyzerTokenStreamConverter_NoErrors.
- return new ToAnalyzerTokenStreamConverter_NoErrors()
- .convertTokens(fastaToken);
- }
+ // round trip test removed
ahe 2017/05/24 21:32:00 Shouldn't you just delete this file?
danrubel 2017/05/25 01:08:15 Good point. Done. https://codereview.chromium.org/
}
class TestScanner extends analyzer.Scanner {
« no previous file with comments | « pkg/front_end/test/scanner_fasta_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698