Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2902803002: disable EdgeImporterBrowserTest.EdgeImporter test. (Closed)

Created:
3 years, 7 months ago by Marijn Kruisselbrink
Modified:
3 years, 7 months ago
Reviewers:
gab
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

disable EdgeImporterBrowserTest.EdgeImporter test. BUG=725364 TBR=gab@chromium.org Review-Url: https://codereview.chromium.org/2902803002 Cr-Commit-Position: refs/heads/master@{#474027} Committed: https://chromium.googlesource.com/chromium/src/+/2c2488064a2355211b457a4808b6fcce99f5f9b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/importer/edge_importer_browsertest_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902803002/1
3 years, 7 months ago (2017-05-23 19:12:44 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/374213) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-05-23 19:19:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902803002/1
3 years, 7 months ago (2017-05-23 20:03:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2c2488064a2355211b457a4808b6fcce99f5f9b6
3 years, 7 months ago (2017-05-23 20:16:16 UTC) #9
gab
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2903573003/ by gab@chromium.org. ...
3 years, 7 months ago (2017-05-23 22:35:47 UTC) #10
Marijn Kruisselbrink
3 years, 7 months ago (2017-05-23 22:42:36 UTC) #11
Message was sent while issue was closed.
On 2017/05/23 at 22:35:47, gab wrote:
> A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2903573003/ by gab@chromium.org.
> 
> The reason for reverting is: No, this is a widespread issue
(http://crbug.com/721245). Please do not disable any tests failing with error
1450 in registry (please re-enable others you may have disabled -- they're not
at fault and we don't want to leave them disabled after the fact...)..

Sorry, my mistake. I somehow misinterpreted an update yesterday in 721245 as
saying that the issue was resolved, so didn't realize that new flakes were still
being caused by it.

Powered by Google App Engine
This is Rietveld 408576698