chrome/android/java/res/values/dimens.xml - Issue 2902793002: Add better handling for very, very small promo dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/values/dimens.xml

Issue 2902793002: Add better handling for very, very small promo dialogs. (Closed)

Patch Set: Address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/android/java/res/values/dimens.xml

diff --git a/chrome/android/java/res/values/dimens.xml b/chrome/android/java/res/values/dimens.xml

index c8b72ead137834360c72f04675232a8cfe45ece8..07639b75e0996f012e8f913a6720a1a46fcb24f4 100644

--- a/chrome/android/java/res/values/dimens.xml

+++ b/chrome/android/java/res/values/dimens.xml

@@ -143,6 +143,7 @@

+ <dimen name="promo_dialog_min_scrollable_height">100dp</dimen>

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialogLayout.java » ('j') | no next file with comments »