Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: chrome/android/java/res/values/dimens.xml

Issue 2902793002: Add better handling for very, very small promo dialogs. (Closed)
Patch Set: Address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialogLayout.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <resources> 6 <resources>
7 <!-- Connection info popup dimensions --> 7 <!-- Connection info popup dimensions -->
8 <dimen name="connection_info_padding_wide">24dp</dimen> 8 <dimen name="connection_info_padding_wide">24dp</dimen>
9 <dimen name="connection_info_padding_thin">16dp</dimen> 9 <dimen name="connection_info_padding_thin">16dp</dimen>
10 10
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 136
137 <!-- Minimum height/width for a touchable item --> 137 <!-- Minimum height/width for a touchable item -->
138 <dimen name="min_touch_target_size">48dp</dimen> 138 <dimen name="min_touch_target_size">48dp</dimen>
139 139
140 <!-- Promo dialogs --> 140 <!-- Promo dialogs -->
141 <dimen name="promo_dialog_illustration_margin">24dp</dimen> 141 <dimen name="promo_dialog_illustration_margin">24dp</dimen>
142 <dimen name="promo_dialog_illustration_width">150dp</dimen> 142 <dimen name="promo_dialog_illustration_width">150dp</dimen>
143 <dimen name="promo_dialog_padding">16dp</dimen> 143 <dimen name="promo_dialog_padding">16dp</dimen>
144 <dimen name="promo_dialog_max_width">600dp</dimen> 144 <dimen name="promo_dialog_max_width">600dp</dimen>
145 <dimen name="promo_dialog_max_content_width">320dp</dimen> 145 <dimen name="promo_dialog_max_content_width">320dp</dimen>
146 <dimen name="promo_dialog_min_scrollable_height">100dp</dimen>
146 <dimen name="promo_dialog_title_text_size">23sp</dimen> 147 <dimen name="promo_dialog_title_text_size">23sp</dimen>
147 <dimen name="promo_dialog_normal_text_size">14sp</dimen> 148 <dimen name="promo_dialog_normal_text_size">14sp</dimen>
148 149
149 <!-- Data Saver --> 150 <!-- Data Saver -->
150 <dimen name="data_usage_chart_height">252dp</dimen> 151 <dimen name="data_usage_chart_height">252dp</dimen>
151 <dimen name="data_reduction_main_menu_icon_width">32dp</dimen> 152 <dimen name="data_reduction_main_menu_icon_width">32dp</dimen>
152 <dimen name="data_saver_menu_footer_min_show_height">240dp</dimen> 153 <dimen name="data_saver_menu_footer_min_show_height">240dp</dimen>
153 154
154 <!-- The size of the text for tab titles. --> 155 <!-- The size of the text for tab titles. -->
155 <dimen name="compositor_tab_title_text_size">13sp</dimen> 156 <dimen name="compositor_tab_title_text_size">13sp</dimen>
(...skipping 321 matching lines...) Expand 10 before | Expand all | Expand 10 after
477 <dimen name="context_menu_header_image_min_size">56dp</dimen> 478 <dimen name="context_menu_header_image_min_size">56dp</dimen>
478 <dimen name="context_menu_header_image_max_size">56dp</dimen> 479 <dimen name="context_menu_header_image_max_size">56dp</dimen>
479 480
480 <!-- Divider Dimensions --> 481 <!-- Divider Dimensions -->
481 <dimen name="divider_height">1dp</dimen> 482 <dimen name="divider_height">1dp</dimen>
482 483
483 <!-- Search widget dimensions --> 484 <!-- Search widget dimensions -->
484 <dimen name="search_activity_location_bar_margin_start">16dp</dimen> 485 <dimen name="search_activity_location_bar_margin_start">16dp</dimen>
485 <dimen name="search_activity_location_bar_margin_end">8dp</dimen> 486 <dimen name="search_activity_location_bar_margin_end">8dp</dimen>
486 </resources> 487 </resources>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialogLayout.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698