The clean up Cl after https://codereview.chromium.org/2898873002/

The clean up Cl after https://codereview.chromium.org/2898873002/

BUG=709360
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2902663002
Cr-Commit-Position: refs/heads/master@{#481129}
Committed: https://chromium.googlesource.com/chromium/src/+/b8247ff416deaf64d757907aabe6d9931a444fed

[wuyingbing1, 2017-05-23 05:45:56]

Description was changed from

==========
The clean up Cl after https://codereview.chromium.org/2898873002/

BUG=709360
==========

to

==========
The clean up Cl after https://codereview.chromium.org/2898873002/

BUG=709360
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[wuyingbing1, 2017-05-23 05:47:14]

Description was changed from

==========
The clean up Cl after https://codereview.chromium.org/2898873002/

BUG=709360
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
The clean up Cl after https://codereview.chromium.org/2898873002/

BUG=709360
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[wuyingbing1, 2017-05-23 05:47:14]

wuyingbing@chromium.org changed reviewers:
+ azurewei@chromium.org, michaelpg@chromium.org, shuchen@chromium.org

[Azure Wei, 2017-05-23 07:32:31]

lgtm

[wuyingbing1, 2017-05-23 07:37:46]

The CQ bit was checked by wuyingbing@chromium.org

[commit-bot: I haz the power, 2017-05-23 07:38:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 07:46:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 07:46:51]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Shu Chen, 2017-05-24 01:22:39]

lgtm

[Shu Chen, 2017-05-24 01:22:43]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2017-05-24 01:24:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 02:23:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 02:23:32]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[wuyingbing1, 2017-05-31 02:18:02]

ping michaelpg

[michaelpg, 2017-05-31 07:53:28]

LGTM, but I'm a bit confused by the difference between
third_party/google_input_tools, google_input_tools_manifest.json, and the
extension with id "gjaehgfemfahhmlgpdfknkhdnemmolop".

Could you please confirm (possibly as a follow-up if necessary):

* Comment in extension_media_access_handler.cc is still correct [1]
* GetInputMethodCategory doesn't need to change [2]
* this works with is_chrome_branded = false (when kT13nExtensionId still refers
to the "gjaehgf..." extension)

[1]
https://cs.chromium.org/chromium/src/chrome/browser/media/extension_media_acc...
[2]
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/input_method/inp...

Thanks!

[wuyingbing, 2017-06-01 00:00:37]

third_party/google_input_tools is open source version of google input tool. 
for extension id "gjaehgfemfahhmlgpdfknkhdnemmolop", maybe chromium version
"google input tools" still use the extension id. Although there are different
extensions.
I will confirm it later. Will hold the CL until I confirm it.

On 2017/05/31 07:53:28, michaelpg wrote:
> LGTM, but I'm a bit confused by the difference between
> third_party/google_input_tools, google_input_tools_manifest.json, and the
> extension with id "gjaehgfemfahhmlgpdfknkhdnemmolop".
> 
> Could you please confirm (possibly as a follow-up if necessary):
> 
> * Comment in extension_media_access_handler.cc is still correct [1]
> * GetInputMethodCategory doesn't need to change [2]
> * this works with is_chrome_branded = false (when kT13nExtensionId still
refers
> to the "gjaehgf..." extension)
> 
> [1]
>
https://cs.chromium.org/chromium/src/chrome/browser/media/extension_media_acc...
> [2]
>
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/input_method/inp...
> 
> Thanks!

[Shu Chen, 2017-06-19 07:05:32]

On 2017/06/01 00:00:37, wuyingbing wrote:
> third_party/google_input_tools is open source version of google input tool. 
> for extension id "gjaehgfemfahhmlgpdfknkhdnemmolop", maybe chromium version
> "google input tools" still use the extension id. Although there are different
> extensions.
> I will confirm it later. Will hold the CL until I confirm it.
I can confirm this cl will affect Chromium OS.

> 
> On 2017/05/31 07:53:28, michaelpg wrote:
> > LGTM, but I'm a bit confused by the difference between
> > third_party/google_input_tools, google_input_tools_manifest.json, and the
> > extension with id "gjaehgfemfahhmlgpdfknkhdnemmolop".
> > 
> > Could you please confirm (possibly as a follow-up if necessary):
> > 
> > * Comment in extension_media_access_handler.cc is still correct [1]
> > * GetInputMethodCategory doesn't need to change [2]
> > * this works with is_chrome_branded = false (when kT13nExtensionId still
> refers
> > to the "gjaehgf..." extension)
> > 
> > [1]
> >
>
https://cs.chromium.org/chromium/src/chrome/browser/media/extension_media_acc...
> > [2]
> >
>
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/input_method/inp...
> > 
> > Thanks!

[Shu Chen, 2017-06-19 07:06:29]

On 2017/06/19 07:05:32, Shu Chen wrote:
> On 2017/06/01 00:00:37, wuyingbing wrote:
> > third_party/google_input_tools is open source version of google input tool. 
> > for extension id "gjaehgfemfahhmlgpdfknkhdnemmolop", maybe chromium version
> > "google input tools" still use the extension id. Although there are
different
> > extensions.
> > I will confirm it later. Will hold the CL until I confirm it.
> I can confirm this cl will affect Chromium OS.
Sorry, I meant "will NOT affect".

> 
> > 
> > On 2017/05/31 07:53:28, michaelpg wrote:
> > > LGTM, but I'm a bit confused by the difference between
> > > third_party/google_input_tools, google_input_tools_manifest.json, and the
> > > extension with id "gjaehgfemfahhmlgpdfknkhdnemmolop".
> > > 
> > > Could you please confirm (possibly as a follow-up if necessary):
> > > 
> > > * Comment in extension_media_access_handler.cc is still correct [1]
> > > * GetInputMethodCategory doesn't need to change [2]
> > > * this works with is_chrome_branded = false (when kT13nExtensionId still
> > refers
> > > to the "gjaehgf..." extension)
> > > 
> > > [1]
> > >
> >
>
https://cs.chromium.org/chromium/src/chrome/browser/media/extension_media_acc...
> > > [2]
> > >
> >
>
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/input_method/inp...
> > > 
> > > Thanks!

[wuyingbing1, 2017-06-19 07:07:04]

The CQ bit was checked by wuyingbing@chromium.org

[commit-bot: I haz the power, 2017-06-19 07:07:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 07:53:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 07:53:02]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[wuyingbing1, 2017-06-21 05:54:07]

The CQ bit was checked by wuyingbing@chromium.org

[commit-bot: I haz the power, 2017-06-21 05:54:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 06:56:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498024447887330, "parent_rev":
"638c26b1f1ba5238cbf4d72075477ab38b15376f", "commit_rev":
"b8247ff416deaf64d757907aabe6d9931a444fed"}

[commit-bot: I haz the power, 2017-06-21 06:57:14]

Description was changed from

==========
The clean up Cl after https://codereview.chromium.org/2898873002/

BUG=709360
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
The clean up Cl after https://codereview.chromium.org/2898873002/

BUG=709360
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2902663002
Cr-Commit-Position: refs/heads/master@{#481129}
Committed:
https://chromium.googlesource.com/chromium/src/+/b8247ff416deaf64d757907aabe6...
==========

[commit-bot: I haz the power, 2017-06-21 06:57:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b8247ff416deaf64d757907aabe6...