Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: content/browser/appcache/appcache_url_loader_factory.h

Issue 2902653002: Get main frame and subframe AppCache loads to work. (Closed)
Patch Set: Fix compile failure by using the host_ member. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/appcache/appcache_url_loader_factory.h
diff --git a/content/browser/appcache/appcache_url_loader_factory.h b/content/browser/appcache/appcache_url_loader_factory.h
index f61539519e6d22a0e698a3da521428d5ca104fe7..9629b3db9898ef754a24d32b266fa641f67078dc 100644
--- a/content/browser/appcache/appcache_url_loader_factory.h
+++ b/content/browser/appcache/appcache_url_loader_factory.h
@@ -11,6 +11,7 @@
#include "url/gurl.h"
namespace content {
+class AppCacheHost;
class ChromeAppCacheService;
class URLLoaderFactoryGetter;
@@ -23,10 +24,17 @@ class AppCacheURLLoaderFactory : public mojom::URLLoaderFactory {
// The |appcache_service| parameter is used to query the underlying
// AppCacheStorage instance to check if we can service requests from the
// AppCache. We pass unhandled requests to the network service retrieved from
- // the |factory_getter|.
+ // the |factory_getter|. The |renderer_process_id| parameter identfies the
+ // renderer process id. In the browser this is -1.
static void CreateURLLoaderFactory(mojom::URLLoaderFactoryRequest request,
ChromeAppCacheService* appcache_service,
- URLLoaderFactoryGetter* factory_getter);
+ URLLoaderFactoryGetter* factory_getter,
+ int renderer_process_id);
+
+ // TODO(ananta)
+ // Get rid of this method once we change the browser side navigation code to
+ // not use URLLoaderFactories.
+ static void SetAppCacheHost(AppCacheHost* host);
// mojom::URLLoaderFactory implementation.
void CreateLoaderAndStart(
@@ -43,7 +51,8 @@ class AppCacheURLLoaderFactory : public mojom::URLLoaderFactory {
private:
AppCacheURLLoaderFactory(ChromeAppCacheService* appcache_service,
- URLLoaderFactoryGetter* factory_getter);
+ URLLoaderFactoryGetter* factory_getter,
+ int renderer_process_id);
// Used to query AppCacheStorage to see if a request can be served out of the
/// AppCache.
@@ -53,6 +62,9 @@ class AppCacheURLLoaderFactory : public mojom::URLLoaderFactory {
// the network service.
scoped_refptr<URLLoaderFactoryGetter> factory_getter_;
+ // The process id of the renderer. -1 in the browser.
+ int renderer_process_id_;
michaeln 2017/05/24 00:59:32 If AppCacheURLLoaderFactory is a per-storagepartit
ananta 2017/05/24 02:14:03 Needs to be revisited after kinuko's changes come
jam 2017/05/24 15:29:02 Since you're not passing a factoryptr to the rende
+
mojo::StrongBindingSet<mojom::URLLoaderFactory> loader_factory_bindings_;
DISALLOW_COPY_AND_ASSIGN(AppCacheURLLoaderFactory);

Powered by Google App Engine
This is Rietveld 408576698