Get main frame and subframe AppCache loads to work.

content/browser/appcache/appcache_url_loader_factory.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_APPCACHE_APPCACHE_URL_LOADER_FACTORY_H_
 #define CONTENT_BROWSER_APPCACHE_APPCACHE_URL_LOADER_FACTORY_H_
 
 #include "base/memory/ref_counted.h"
 #include "content/common/url_loader_factory.mojom.h"
 #include "mojo/public/cpp/bindings/strong_binding_set.h"
 #include "url/gurl.h"
 
 namespace content {
+class AppCacheHost;
 class ChromeAppCacheService;
 class URLLoaderFactoryGetter;
 
 // Implements the URLLoaderFactory mojom for AppCache requests.
 class AppCacheURLLoaderFactory : public mojom::URLLoaderFactory {

[michaeln, 2017/05/24 00:59:32]

How about we make this class specific to MainResource loads too.

Why does this class that exposes mojo methods? I think the consumer of this
factory is navigation code that runs in the same process.

[ananta, 2017/05/24 02:14:03]

This class exposes mojo methods because it implements the URLLoaderFactory
mojom. Once kinuko lands her changes to not use the factory in the browser, we
will revisit this. This factory will be 
passed to the renderer for subresources.

  public:
   ~AppCacheURLLoaderFactory() override;
 
   // Factory function to create an instance of the factory.
   // The |appcache_service| parameter is used to query the underlying
   // AppCacheStorage instance to check if we can service requests from the
   // AppCache. We pass unhandled requests to the network service retrieved from
-  // the |factory_getter|.
+  // the |factory_getter|. The |renderer_process_id| parameter identfies the
+  // renderer process id. In the browser this is -1.
   static void CreateURLLoaderFactory(mojom::URLLoaderFactoryRequest request,
                                      ChromeAppCacheService* appcache_service,
-                                     URLLoaderFactoryGetter* factory_getter);
+                                     URLLoaderFactoryGetter* factory_getter,
+                                     int renderer_process_id);
+
+  // TODO(ananta)
+  // Get rid of this method once we change the browser side navigation code to
+  // not use URLLoaderFactories.
+  static void SetAppCacheHost(AppCacheHost* host);
 
   // mojom::URLLoaderFactory implementation.
   void CreateLoaderAndStart(
       mojom::URLLoaderAssociatedRequest url_loader_request,
       int32_t routing_id,
       int32_t request_id,
       uint32_t options,
       const ResourceRequest& request,
       mojom::URLLoaderClientPtr client) override;
   void SyncLoad(int32_t routing_id,
                 int32_t request_id,
                 const ResourceRequest& request,
                 SyncLoadCallback callback) override;
 
  private:
   AppCacheURLLoaderFactory(ChromeAppCacheService* appcache_service,
-                           URLLoaderFactoryGetter* factory_getter);
+                           URLLoaderFactoryGetter* factory_getter,
+                           int renderer_process_id);
 
   // Used to query AppCacheStorage to see if a request can be served out of the
   /// AppCache.
   scoped_refptr<ChromeAppCacheService> appcache_service_;
 
   // Used to retrieve the network service factory to pass unhandled requests to
   // the network service.
   scoped_refptr<URLLoaderFactoryGetter> factory_getter_;
 
+  // The process id of the renderer. -1 in the browser.
+  int renderer_process_id_;

[michaeln, 2017/05/24 00:59:32]

If AppCacheURLLoaderFactory is a per-storagepartition object (i think it is), I
don't think this datamember belongs here.

[ananta, 2017/05/24 02:14:03]

Needs to be revisited after kinuko's changes come in. If needed we will have a
new class which handles navigation side code for AppCache with the factory only
used for subresources.

[jam, 2017/05/24 15:29:02]

Since you're not passing a factoryptr to the renderer yet, what's the need to
have a renderer process id in this class since it's always -1?

+
   mojo::StrongBindingSet<mojom::URLLoaderFactory> loader_factory_bindings_;
 
   DISALLOW_COPY_AND_ASSIGN(AppCacheURLLoaderFactory);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_APPCACHE_APPCACHE_URL_LOADER_FACTORY_H_