Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2902573002: Flip the IPH rectangle highlight animation (Closed)

Created:
3 years, 7 months ago by David Trainor- moved to gerrit
Modified:
3 years, 7 months ago
Reviewers:
nyquist
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip the IPH rectangle highlight animation The rectangle highlight was mostly faded out, with an occasional pulse to fade in. The spec calls for the opposite. Switching the animation. BUG=724996 Review-Url: https://codereview.chromium.org/2902573002 Cr-Commit-Position: refs/heads/master@{#473961} Committed: https://chromium.googlesource.com/chromium/src/+/90510452784fec4a2b9b84d8018606e6d42b4044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/widget/PulseDrawable.java View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
David Trainor- moved to gerrit
ptal thanks!
3 years, 7 months ago (2017-05-22 20:07:00 UTC) #2
nyquist
lgtm
3 years, 7 months ago (2017-05-22 20:31:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902573002/1
3 years, 7 months ago (2017-05-23 16:54:14 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 17:38:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90510452784fec4a2b9b84d80186...

Powered by Google App Engine
This is Rietveld 408576698