Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2902563003: Change to whitespace_file.txt, first commit, trying things out! (Closed)

Created:
3 years, 7 months ago by jzeisloft
Modified:
3 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change to whitespace_file.txt, first commit, trying things out! BUG= Review-Url: https://codereview.chromium.org/2902563003 Cr-Commit-Position: refs/heads/master@{#473726} Committed: https://chromium.googlesource.com/chromium/src/+/9c25d23240cd803b3afd6247655192ca78eca774

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/whitespace_file.txt View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (4 generated)
jzeisloft
3 years, 7 months ago (2017-05-22 22:04:05 UTC) #2
Nico
lgtm https://codereview.chromium.org/2902563003/diff/1/build/whitespace_file.txt File build/whitespace_file.txt (right): https://codereview.chromium.org/2902563003/diff/1/build/whitespace_file.txt#newcode64 build/whitespace_file.txt:64: $CHAPTER6 I really like how this pulls the ...
3 years, 7 months ago (2017-05-22 22:05:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902563003/1
3 years, 7 months ago (2017-05-22 22:08:12 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 22:24:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c25d23240cd803b3afd62476551...

Powered by Google App Engine
This is Rietveld 408576698