DevTools: migrate WatchExpressionsSidebarPane to shadow

DevTools: migrate WatchExpressionsSidebarPane to shadow

BUG=726972
Review-Url: https://codereview.chromium.org/2902543002
Cr-Commit-Position: refs/heads/master@{#475636}
Committed: https://chromium.googlesource.com/chromium/src/+/0c645f037a2eb0950b6447c206c6fdda3e6bf32a

[luoe, 2017-05-22 18:42:52]

luoe@chromium.org changed reviewers:
+ dgozman@chromium.org

[luoe, 2017-05-22 18:42:53]

Please take a look

This is part of an effort to move more things into components.

Some of the css rules are unused/need cleaning, but I'd like to do clean sources
styles together in a separate patch.

[luoe, 2017-05-24 23:35:16]

Description was changed from

==========
DevTools: migrate WatchExpressionsSidebarPane to shadow

BUG=none
==========

to

==========
DevTools: migrate WatchExpressionsSidebarPane to shadow

BUG=none
==========

[luoe, 2017-05-24 23:35:16]

luoe@chromium.org changed reviewers:
+ einbinder@chromium.org

[einbinder, 2017-05-25 00:14:05]

lgtm

Maybe there should be a tracking bug for these patches?

[dgozman, 2017-05-25 00:22:05]

lgtm

https://codereview.chromium.org/2902543002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/watchExpressionsSidebarPane.css
(right):

https://codereview.chromium.org/2902543002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/watchExpressionsSidebarPane.css:104:
.sidebar-pane-stack .watch-expressions {
Just remove it.

[luoe, 2017-05-27 03:02:39]

Description was changed from

==========
DevTools: migrate WatchExpressionsSidebarPane to shadow

BUG=none
==========

to

==========
DevTools: migrate WatchExpressionsSidebarPane to shadow

BUG=726972
==========

[luoe, 2017-05-27 03:04:47]

https://codereview.chromium.org/2902543002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/watchExpressionsSidebarPane.css
(right):

https://codereview.chromium.org/2902543002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/watchExpressionsSidebarPane.css:104:
.sidebar-pane-stack .watch-expressions {
On 2017/05/25 00:22:05, dgozman wrote:
> Just remove it.

Done.

[luoe, 2017-05-27 03:04:54]

The CQ bit was checked by luoe@chromium.org

[luoe, 2017-05-27 03:04:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
einbinder@chromium.org, dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2902543002/#ps20001
(title: "ac")

[commit-bot: I haz the power, 2017-05-27 03:05:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 05:17:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-27 05:17:50]

Failed to apply patch for
third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css:68
  Falling back to three-way merge...
  Applied patch to
'third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css' with
conflicts.
  U third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css

Patch:      
third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css
Index: third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css
diff --git
a/third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css
b/third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css
index
f47ab98f3bc7cd33a18f81544a414be6ff8cd750..d94e342d05304a2b8b0d7dde524c6dd944116dbd
100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css
+++ b/third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css
@@ -68,107 +68,6 @@
     cursor: auto;
 }
 
-.watch-expression-delete-button {
-    width: 10px;
-    height: 10px;
-    background-image: url(Images/deleteIcon.png);
-    background-position: 0 0;
-    background-color: transparent;
-    background-repeat: no-repeat;
-    border: 0 none transparent;
-    position: absolute;
-    top: 4px;
-    right: 3px;
-    display: none;
-}
-
-.watch-expression-header:hover .watch-expression-delete-button {
-    display: inline;
-}
-
-.watch-expressions {
-    overflow-x: hidden;
-    min-height: 26px;
-}
-
-.watch-expressions .dimmed {
-    opacity: 0.6;
-}
-
-.watch-expression-title {
-    white-space: nowrap;
-    text-overflow: ellipsis;
-    overflow: hidden;
-    line-height: 16px;
-    margin-left: 11px;
-}
-
-.watch-expression-object-header .watch-expression-title {
-    margin-left: 1px;
-}
-
-.watch-expression {
-    position: relative;
-    padding: 1px 0px 1px 6px;
-    flex: none;
-    min-height: 20px;
-}
-
-.watch-expressions .name {
-    color: rgb(136, 19, 145);
-    flex: none;
-    white-space: nowrap;
-    text-overflow: ellipsis ;
-    overflow: hidden;
-}
-
-.watch-expression-error {
-    color: red;
-}
-
-.-theme-with-dark-background .watch-expression-error {
-    color: hsl(0, 100%, 65%);
-}
-
-.watch-expressions-separator {
-    flex: none;
-}
-
-.watch-expressions .value {
-    white-space: nowrap;
-    display: inline;
-}
-
-.watch-expression .text-prompt {
-    text-overflow: clip;
-    overflow: hidden;
-    white-space: nowrap;
-    padding-left: 4px;
-    -webkit-user-select: text;
-}
-
-.watch-expression-text-prompt-proxy {
-    margin-left: 12px;
-}
-
-.watch-expression-header {
-    flex: auto;
-}
-
-.watch-expression-object-header {
-    margin-left: -12px;
-    padding-left: 12px;
-}
-
-.watch-expression-header:hover {
-    background-color: #F0F0F0;
-    padding-right: 14px;
-}
-
-.sidebar-pane-stack .watch-expressions {
-    margin-top: 0px;
-}
-
 .scope-chain-sidebar-pane-section-header {
     flex: auto;
 }

[luoe, 2017-05-30 17:44:43]

The CQ bit was checked by luoe@chromium.org

[luoe, 2017-05-30 17:44:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
einbinder@chromium.org, dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2902543002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-30 17:45:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 20:00:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496166283271710,
"parent_rev": "446b566d645551d8e592db6264691327d86d1424", "commit_rev":
"0c645f037a2eb0950b6447c206c6fdda3e6bf32a"}

[commit-bot: I haz the power, 2017-05-30 20:00:43]

Description was changed from

==========
DevTools: migrate WatchExpressionsSidebarPane to shadow

BUG=726972
==========

to

==========
DevTools: migrate WatchExpressionsSidebarPane to shadow

BUG=726972

Review-Url: https://codereview.chromium.org/2902543002
Cr-Commit-Position: refs/heads/master@{#475636}
Committed:
https://chromium.googlesource.com/chromium/src/+/0c645f037a2eb0950b6447c206c6...
==========

[commit-bot: I haz the power, 2017-05-30 20:00:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0c645f037a2eb0950b6447c206c6...