[turbofan] Add support for inlining accessors into try-blocks.

[turbofan] Add support for inlining accessors into try-blocks.

Previously the inlining of accessors into try-blocks (i.e. try/catch,
try/finally, for-of, etc.) was disabled in JSNativeContextSpecialization,
which prevented a couple of interesting optimizations, i.e. we end up
with a LOAD_IC in optimized code for this simple example:

  class A { get x() { return 1; } }
  function foo(a) {
    try {
      return a.x;
    } catch (e) {
      return 0;
    }
  }
  foo(new A)

This is now fixed and the accessors are properly rewired into the
handler chain.

BUG=v8:6278, v8:6344, v8:6424
R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2902533003
Cr-Commit-Position: refs/heads/master@{#45485}
Committed: https://chromium.googlesource.com/v8/v8/+/9dbafbd5d3eeab36fb8aaa48185bd228658783f6

[Benedikt Meurer, 2017-05-22 19:45:02]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 19:45:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 20:13:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 20:13:54]

Dry run: This issue passed the CQ dry run.

[Jarin, 2017-05-22 20:23:38]

Please, write tests for this, including throwing into lazy deopted code.

https://codereview.chromium.org/2902533003/diff/1/src/compiler/js-native-cont...
File src/compiler/js-native-context-specialization.cc (right):

https://codereview.chromium.org/2902533003/diff/1/src/compiler/js-native-cont...
src/compiler/js-native-context-specialization.cc:929:
DCHECK_NOT_NULL(if_exceptions);
DCHECK(&if_exception_nodes == if_exceptions);

https://codereview.chromium.org/2902533003/diff/1/src/compiler/js-native-cont...
File src/compiler/js-native-context-specialization.h (right):

https://codereview.chromium.org/2902533003/diff/1/src/compiler/js-native-cont...
src/compiler/js-native-context-specialization.h:117: AccessMode access_mode,
LanguageMode language_mode);
OMG!

[Benedikt Meurer, 2017-05-23 08:50:36]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 08:50:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 09:46:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 09:47:00]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2017-05-23 11:06:26]

https://codereview.chromium.org/2902533003/diff/1/src/compiler/js-native-cont...
File src/compiler/js-native-context-specialization.cc (right):

https://codereview.chromium.org/2902533003/diff/1/src/compiler/js-native-cont...
src/compiler/js-native-context-specialization.cc:929:
DCHECK_NOT_NULL(if_exceptions);
On 2017/05/22 20:23:37, Jarin wrote:
> DCHECK(&if_exception_nodes == if_exceptions);

Done.

https://codereview.chromium.org/2902533003/diff/1/src/compiler/js-native-cont...
File src/compiler/js-native-context-specialization.h (right):

https://codereview.chromium.org/2902533003/diff/1/src/compiler/js-native-cont...
src/compiler/js-native-context-specialization.h:117: AccessMode access_mode,
LanguageMode language_mode);
On 2017/05/22 20:23:38, Jarin wrote:
> OMG!

Acknowledged.

[Jarin, 2017-05-23 11:06:49]

lgtm

[Benedikt Meurer, 2017-05-23 11:09:11]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-05-23 11:09:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 12:02:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495537751903970,
"parent_rev": "d085eee20d0b2cf0722029e1bb3fe65e963382bf", "commit_rev":
"9dbafbd5d3eeab36fb8aaa48185bd228658783f6"}

[commit-bot: I haz the power, 2017-05-23 12:02:35]

Description was changed from

==========
[turbofan] Add support for inlining accessors into try-blocks.

Previously the inlining of accessors into try-blocks (i.e. try/catch,
try/finally, for-of, etc.) was disabled in JSNativeContextSpecialization,
which prevented a couple of interesting optimizations, i.e. we end up
with a LOAD_IC in optimized code for this simple example:

  class A { get x() { return 1; } }
  function foo(a) {
    try {
      return a.x;
    } catch (e) {
      return 0;
    }
  }
  foo(new A)

This is now fixed and the accessors are properly rewired into the
handler chain.

BUG=v8:6278,v8:6344,v8:6424
R=jarin@chromium.org
==========

to

==========
[turbofan] Add support for inlining accessors into try-blocks.

Previously the inlining of accessors into try-blocks (i.e. try/catch,
try/finally, for-of, etc.) was disabled in JSNativeContextSpecialization,
which prevented a couple of interesting optimizations, i.e. we end up
with a LOAD_IC in optimized code for this simple example:

  class A { get x() { return 1; } }
  function foo(a) {
    try {
      return a.x;
    } catch (e) {
      return 0;
    }
  }
  foo(new A)

This is now fixed and the accessors are properly rewired into the
handler chain.

BUG=v8:6278,v8:6344,v8:6424
R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2902533003
Cr-Commit-Position: refs/heads/master@{#45485}
Committed:
https://chromium.googlesource.com/v8/v8/+/9dbafbd5d3eeab36fb8aaa48185bd228658...
==========

[commit-bot: I haz the power, 2017-05-23 12:02:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/9dbafbd5d3eeab36fb8aaa48185bd228658...