Expose the language to Android accessibility services using LocaleSpans

Expose the language to Android accessibility services using LocaleSpans

TalkBack and other accessibility services on Android now pay attention to
LocaleSpans to determine what language to use when speaking text. Wrap
text in AccessibilityNodeInfo in a LocaleSpan indicating the correct
language, but for efficiency, only do this when it's different than the
system language.

BUG=725134
Review-Url: https://codereview.chromium.org/2902533002
Cr-Commit-Position: refs/heads/master@{#473989}
Committed: https://chromium.googlesource.com/chromium/src/+/b548f9cf279046ffad8e2eae5dc1f63ebaf1cd43

[dmazzoni, 2017-05-22 17:48:46]

dmazzoni@chromium.org changed reviewers:
+ paulmiller@chromium.org

[dmazzoni, 2017-05-22 17:48:51]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 17:49:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 18:43:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 18:44:00]

Dry run: This issue passed the CQ dry run.

[paulmiller, 2017-05-22 20:37:29]

https://codereview.chromium.org/2902533002/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java
(right):

https://codereview.chromium.org/2902533002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java:34:
mSystemLanguageTag = Locale.getDefault().toLanguageTag();
Maybe we shouldn't cache this; what happens if the user changes the locale while
Chrome/WebView is running? In N, it looks like there can also be multiple
locales:
https://developer.android.com/guide/topics/resources/multilingual-support.html

[dmazzoni, 2017-05-23 16:56:18]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 16:57:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-05-23 17:02:57]

https://codereview.chromium.org/2902533002/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java
(right):

https://codereview.chromium.org/2902533002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java:34:
mSystemLanguageTag = Locale.getDefault().toLanguageTag();
On 2017/05/22 20:37:29, paulmiller wrote:
> Maybe we shouldn't cache this; what happens if the user changes the locale
while
> Chrome/WebView is running?

Good thought. I added a BroadcastReceiver so that we can be
notified when it changes.

I still think it's good to cache it since this function is
sometimes called thousands of times a second and I want
to minimize unnecessary system calls.

> In N, it looks like there can also be multiple
> locales:
> https://developer.android.com/guide/topics/resources/multilingual-support.html

That's true, but for this application we want to tag everything with a language
- this is just an optimization to skip it if it matches the default locale
language, as long as TalkBack uses the same rule when decoding it.

[paulmiller, 2017-05-23 17:14:15]

https://codereview.chromium.org/2902533002/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java
(right):

https://codereview.chromium.org/2902533002/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java:40:
mSystemLanguageTag = Locale.getDefault().toLanguageTag();
This looks like a race condition (although it'd be very unlikely for it to
happen), if the locale changes in between the first cache and setting up the
listener.

[dmazzoni, 2017-05-23 17:16:18]

https://codereview.chromium.org/2902533002/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java
(right):

https://codereview.chromium.org/2902533002/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java:40:
mSystemLanguageTag = Locale.getDefault().toLanguageTag();
On 2017/05/23 17:14:15, paulmiller wrote:
> This looks like a race condition (although it'd be very unlikely for it to
> happen), if the locale changes in between the first cache and setting up the
> listener.

Good thought, switched the order.

[dmazzoni, 2017-05-23 17:16:26]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 17:16:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[paulmiller, 2017-05-23 17:25:24]

On 2017/05/23 17:16:18, dmazzoni wrote:
>
https://codereview.chromium.org/2902533002/diff/20001/content/public/android/...
> File
>
content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java
> (right):
> 
>
https://codereview.chromium.org/2902533002/diff/20001/content/public/android/...
>
content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java:40:
> mSystemLanguageTag = Locale.getDefault().toLanguageTag();
> On 2017/05/23 17:14:15, paulmiller wrote:
> > This looks like a race condition (although it'd be very unlikely for it to
> > happen), if the locale changes in between the first cache and setting up the
> > listener.
> 
> Good thought, switched the order.

lgtm

[dmazzoni, 2017-05-23 17:49:55]

The CQ bit was unchecked by dmazzoni@chromium.org

[dmazzoni, 2017-05-23 17:49:59]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-05-23 17:50:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 18:24:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495561799866840,
"parent_rev": "1d0405c889b2cd86524aa1cb277c658eba563078", "commit_rev":
"f9de84f43bf67b7afeb27450e875c4ab1f0fb406"}

[commit-bot: I haz the power, 2017-05-23 18:24:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495561799866840,
"parent_rev": "baf703ffaca53d257628f5244df99c86efbd576c", "commit_rev":
"b548f9cf279046ffad8e2eae5dc1f63ebaf1cd43"}

[commit-bot: I haz the power, 2017-05-23 18:24:43]

Description was changed from

==========
Expose the language to Android accessibility services using LocaleSpans

TalkBack and other accessibility services on Android now pay attention to
LocaleSpans to determine what language to use when speaking text. Wrap
text in AccessibilityNodeInfo in a LocaleSpan indicating the correct
language, but for efficiency, only do this when it's different than the
system language.

BUG=725134
==========

to

==========
Expose the language to Android accessibility services using LocaleSpans

TalkBack and other accessibility services on Android now pay attention to
LocaleSpans to determine what language to use when speaking text. Wrap
text in AccessibilityNodeInfo in a LocaleSpan indicating the correct
language, but for efficiency, only do this when it's different than the
system language.

BUG=725134

Review-Url: https://codereview.chromium.org/2902533002
Cr-Commit-Position: refs/heads/master@{#473989}
Committed:
https://chromium.googlesource.com/chromium/src/+/b548f9cf279046ffad8e2eae5dc1...
==========

[commit-bot: I haz the power, 2017-05-23 18:24:45]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b548f9cf279046ffad8e2eae5dc1...