Use same document term instead of in-page in NavigationControllerTest.

Use same document term instead of in-page in NavigationControllerTest.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2902513003
Cr-Commit-Position: refs/heads/master@{#474095}
Committed: https://chromium.googlesource.com/chromium/src/+/a1ebacdb1bbacbf534ef9f8dc763bc77273fdfd0

[Eugene But (OOO till 7-30), 2017-05-22 22:39:55]

Description was changed from

==========
Use same document term instead of in-page in NavigationControllerTest.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
==========

to

==========
Use same document term instead of in-page in NavigationControllerTest.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Eugene But (OOO till 7-30), 2017-05-22 22:40:02]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 22:40:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 23:11:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 23:11:49]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-05-22 23:14:50]

eugenebut@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2017-05-22 23:31:32]

Thanks!  LGTM with nits.

https://codereview.chromium.org/2902513003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_controller_impl_unittest.cc (right):

https://codereview.chromium.org/2902513003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl_unittest.cc:2624:
TEST_F(NavigationControllerTest, InPage) {
Do you want to get this test name while we're modifying it?

https://codereview.chromium.org/2902513003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl_unittest.cc:2726: //
Finally, navigate to an unrelated URL to make sure in_page is not sticky.
Let's update this as well.

https://codereview.chromium.org/2902513003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl_unittest.cc:2746:
TEST_F(NavigationControllerTest, InPage_Replace) {
Same.

[Eugene But (OOO till 7-30), 2017-05-23 00:08:02]

Thanks for a quick review!

https://codereview.chromium.org/2902513003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_controller_impl_unittest.cc (right):

https://codereview.chromium.org/2902513003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl_unittest.cc:2624:
TEST_F(NavigationControllerTest, InPage) {
On 2017/05/22 23:31:32, Charlie Reis wrote:
> Do you want to get this test name while we're modifying it?
I thought that test name is still valid, because this test loads the same page
(see "Ensure main page navigation to same url respects the" comment). Which name
would you prefer?

https://codereview.chromium.org/2902513003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl_unittest.cc:2726: //
Finally, navigate to an unrelated URL to make sure in_page is not sticky.
On 2017/05/22 23:31:32, Charlie Reis wrote:
> Let's update this as well.

Done.

https://codereview.chromium.org/2902513003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl_unittest.cc:2746:
TEST_F(NavigationControllerTest, InPage_Replace) {
On 2017/05/22 23:31:31, Charlie Reis wrote:
> Same.

Done.

[Charlie Reis, 2017-05-23 18:50:54]

Thanks!  Still looks good once the test name is updated.

https://codereview.chromium.org/2902513003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_controller_impl_unittest.cc (right):

https://codereview.chromium.org/2902513003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl_unittest.cc:2624:
TEST_F(NavigationControllerTest, InPage) {
On 2017/05/23 00:08:02, Eugene But wrote:
> On 2017/05/22 23:31:32, Charlie Reis wrote:
> > Do you want to get this test name while we're modifying it?
> I thought that test name is still valid, because this test loads the same page
> (see "Ensure main page navigation to same url respects the" comment). Which
name
> would you prefer?

No, I think it's referring to the classification in all of these cases, which
we're now calling same-document.  Let's update the test name as well.

[Eugene But (OOO till 7-30), 2017-05-23 19:31:44]

https://codereview.chromium.org/2902513003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_controller_impl_unittest.cc (right):

https://codereview.chromium.org/2902513003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_controller_impl_unittest.cc:2624:
TEST_F(NavigationControllerTest, InPage) {
On 2017/05/23 18:50:53, Charlie Reis wrote:
> On 2017/05/23 00:08:02, Eugene But wrote:
> > On 2017/05/22 23:31:32, Charlie Reis wrote:
> > > Do you want to get this test name while we're modifying it?
> > I thought that test name is still valid, because this test loads the same
page
> > (see "Ensure main page navigation to same url respects the" comment). Which
> name
> > would you prefer?
> 
> No, I think it's referring to the classification in all of these cases, which
> we're now calling same-document.  Let's update the test name as well.

Done.

[Eugene But (OOO till 7-30), 2017-05-23 19:31:52]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-05-23 19:31:53]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2902513003/#ps40001
(title: "Renamed InPage test to SameDocument")

[commit-bot: I haz the power, 2017-05-23 19:33:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 19:41:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 19:41:25]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eugene But (OOO till 7-30), 2017-05-23 22:21:43]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-05-23 22:22:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 22:58:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495578103346540,
"parent_rev": "22fe16d8f7f7df6358a93e5fc432192c436c4f2a", "commit_rev":
"a1ebacdb1bbacbf534ef9f8dc763bc77273fdfd0"}

[commit-bot: I haz the power, 2017-05-23 22:59:01]

Description was changed from

==========
Use same document term instead of in-page in NavigationControllerTest.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Use same document term instead of in-page in NavigationControllerTest.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2902513003
Cr-Commit-Position: refs/heads/master@{#474095}
Committed:
https://chromium.googlesource.com/chromium/src/+/a1ebacdb1bbacbf534ef9f8dc763...
==========

[commit-bot: I haz the power, 2017-05-23 22:59:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a1ebacdb1bbacbf534ef9f8dc763...