Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Unified Diff: chrome/browser/android/vr_shell/vr_shell.cc

Issue 2902393002: [vr] Bail on unhandled code points. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/vr_shell.cc
diff --git a/chrome/browser/android/vr_shell/vr_shell.cc b/chrome/browser/android/vr_shell/vr_shell.cc
index 5a7be6589489881e3cbf47642b854a59b9b20a83..3905c109b722f7608c83ed2ad7bca6905fa02922 100644
--- a/chrome/browser/android/vr_shell/vr_shell.cc
+++ b/chrome/browser/android/vr_shell/vr_shell.cc
@@ -87,6 +87,9 @@ void SetIsInVR(content::WebContents* contents, bool is_in_vr) {
}
}
+static const char* kUnsupportedModeHistogramName =
Ilya Sherman 2017/05/26 22:19:51 nit: no need for "static" in the anonymous namespa
Ilya Sherman 2017/05/26 22:19:51 nit: const char kUnsupportedModeHistogramName[] =
Mark P 2017/05/26 22:29:18 If it's only used in one place, why not use the "s
Ian Vollick 2017/05/27 00:02:44 Removed as per mpearson's comment.
Ian Vollick 2017/05/27 00:02:44 Done.
Ian Vollick 2017/05/27 00:02:44 Nuked.
+ "VR.Shell.EncounteredUnsupportedMode";
+
} // namespace
VrShell::VrShell(JNIEnv* env,
@@ -582,12 +585,14 @@ void VrShell::ExitFullscreen() {
}
}
-void VrShell::ExitVrDueToUnsupportedMode() {
+void VrShell::ExitVrDueToUnsupportedMode(UiUnsupportedMode mode) {
ui_->SetIsExiting();
main_thread_task_runner_->PostDelayedTask(
FROM_HERE,
base::Bind(&VrShell::ForceExitVr, weak_ptr_factory_.GetWeakPtr()),
kExitVrDueToUnsupportedModeDelay);
+ UMA_HISTOGRAM_ENUMERATION(kUnsupportedModeHistogramName, mode,
+ UiUnsupportedMode::kMax);
}
void VrShell::OnVRVsyncProviderRequest(

Powered by Google App Engine
This is Rietveld 408576698