[vr] Bail on unhandled code points.

chrome/browser/android/vr_shell/vr_shell.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/vr_shell.h"
 
 #include <android/native_window_jni.h>
 
 #include <string>
 #include <utility>
@@ skipping 69 matching lines @@
     // should add a flag for disabling specific UI such as the keyboard (see
     // VrTabHelper for details).
     contents->GetRenderWidgetHostView()->SetIsInVR(is_in_vr);
 
     VrTabHelper* vr_tab_helper = VrTabHelper::FromWebContents(contents);
     DCHECK(vr_tab_helper);
     vr_tab_helper->SetIsInVr(is_in_vr);
   }
 }
 
+static const char* kUnsupportedModeHistogramName =

[Ilya Sherman, 2017/05/26 22:19:51]

nit: no need for "static" in the anonymous namespace.

[Ilya Sherman, 2017/05/26 22:19:51]

nit: const char kUnsupportedModeHistogramName[] =

(and possibly "constexpr" in place of "const" -- I'm not sure whether there's
any reason to prefer one or the other in a case like this)

[Mark P, 2017/05/26 22:29:18]

If it's only used in one place, why not use the "string" in that place?

[Ian Vollick, 2017/05/27 00:02:44]

Removed as per mpearson's comment.

[Ian Vollick, 2017/05/27 00:02:44]

Done.

[Ian Vollick, 2017/05/27 00:02:44]

Nuked.

+    "VR.Shell.EncounteredUnsupportedMode";
+
 }  // namespace
 
 VrShell::VrShell(JNIEnv* env,
                  jobject obj,
                  ui::WindowAndroid* window,
                  bool for_web_vr,
                  bool in_cct,
                  VrShellDelegate* delegate,
                  gvr_context* gvr_api,
                  bool reprojected_rendering)
@@ skipping 475 matching lines @@
 void VrShell::ExitPresent() {
   delegate_provider_->ExitWebVRPresent();
 }
 
 void VrShell::ExitFullscreen() {
   if (web_contents_ && web_contents_->IsFullscreen()) {
     web_contents_->ExitFullscreen(false);
   }
 }
 
-void VrShell::ExitVrDueToUnsupportedMode() {
+void VrShell::ExitVrDueToUnsupportedMode(UiUnsupportedMode mode) {
   ui_->SetIsExiting();
   main_thread_task_runner_->PostDelayedTask(
       FROM_HERE,
       base::Bind(&VrShell::ForceExitVr, weak_ptr_factory_.GetWeakPtr()),
       kExitVrDueToUnsupportedModeDelay);
+  UMA_HISTOGRAM_ENUMERATION(kUnsupportedModeHistogramName, mode,
+                            UiUnsupportedMode::kMax);
 }
 
 void VrShell::OnVRVsyncProviderRequest(
     device::mojom::VRVSyncProviderRequest request) {
   WaitForGlThread();
   PostToGlThread(FROM_HERE,
                  base::Bind(&VrShellGl::OnRequest, gl_thread_->GetVrShellGl(),
                             base::Passed(&request)));
 }
 
@@ skipping 122 matching lines @@
            jlong gvr_api,
            jboolean reprojected_rendering) {
   return reinterpret_cast<intptr_t>(new VrShell(
       env, obj, reinterpret_cast<ui::WindowAndroid*>(window_android),
       for_web_vr, in_cct,
       VrShellDelegate::GetNativeVrShellDelegate(env, delegate),
       reinterpret_cast<gvr_context*>(gvr_api), reprojected_rendering));
 }
 
 }  // namespace vr_shell