Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2902383003:
Don't log to stderr during GPU process watchdog timeout (Closed)
DescriptionDon't log to stderr during GPU process watchdog timeout
It's possible stderr's buffer is full and that's causing the main thread
to hang, so just attempt to send the error message to the browser
process instead of possibly blocking as well.
BUG=609252
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2902383003
Cr-Commit-Position: refs/heads/master@{#474878}
Committed: https://chromium.googlesource.com/chromium/src/+/d5e5040512747a4654b34c6ebaf0a301fb755f43
Patch Set 1 #Patch Set 2 : change format string #Patch Set 3 : fix format string #Messages
Total messages: 24 (17 generated)
Description was changed from ========== Don't log to stderr during GPU process watchdog timeout It's possible stderr's buffer is full and that's causing the main thread to hang, so just attempt to send the error message to the browser process instead of possibly blocking as well. BUG=609252 ========== to ========== Don't log to stderr during GPU process watchdog timeout It's possible stderr's buffer is full and that's causing the main thread to hang, so just attempt to send the error message to the browser process instead of possibly blocking as well. BUG=609252 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by jbauman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jbauman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
The CQ bit was checked by jbauman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
jbauman@chromium.org changed reviewers: + vmiura@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM to try, though I'm wondering what's the chance the IPC succeeds before we crash the GPU process.
The CQ bit was checked by jbauman@chromium.org
On 2017/05/26 01:59:07, vmiura wrote: > LGTM to try, though I'm wondering what's the chance the IPC succeeds before we > crash the GPU process. Btw, I'm working on a patch that should fix the issue in the GPU tests by always diverting the stderr/stdout to a temporary file and reading that later for test logging.
On 2017/05/26 01:59:07, vmiura wrote: > LGTM to try, though I'm wondering what's the chance the IPC succeeds before we > crash the GPU process. Btw, I'm working on a patch that should fix the issue in the GPU tests by always diverting the stderr/stdout to a temporary file and reading that later for test logging.
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/26 02:01:26, vmiura wrote: > On 2017/05/26 01:59:07, vmiura wrote: > > LGTM to try, though I'm wondering what's the chance the IPC succeeds before we > > crash the GPU process. > I suspect pretty low, but it's worth a shot. > Btw, I'm working on a patch that should fix the issue in the GPU tests by always > diverting the stderr/stdout to a temporary file and reading that later for test > logging. Ok, sounds good. I'm also curious if this does anything for our uploaded crash dumps from canary.
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495764053773960,
"parent_rev": "75fce5f4280450d1b54c47aa06235ae67bade43d", "commit_rev":
"d5e5040512747a4654b34c6ebaf0a301fb755f43"}
Message was sent while issue was closed.
Description was changed from ========== Don't log to stderr during GPU process watchdog timeout It's possible stderr's buffer is full and that's causing the main thread to hang, so just attempt to send the error message to the browser process instead of possibly blocking as well. BUG=609252 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Don't log to stderr during GPU process watchdog timeout It's possible stderr's buffer is full and that's causing the main thread to hang, so just attempt to send the error message to the browser process instead of possibly blocking as well. BUG=609252 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2902383003 Cr-Commit-Position: refs/heads/master@{#474878} Committed: https://chromium.googlesource.com/chromium/src/+/d5e5040512747a4654b34c6ebaf0... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/d5e5040512747a4654b34c6ebaf0... |
