Fix HttpNetworkTransactionTest.UseIPConnectionPoolingWithHostCacheExpiration.

Fix HttpNetworkTransactionTest.UseIPConnectionPoolingWithHostCacheExpiration.

BUG=726027
Review-Url: https://codereview.chromium.org/2902383002
Cr-Commit-Position: refs/heads/master@{#474773}
Committed: https://chromium.googlesource.com/chromium/src/+/6dcd8194cc47b97f5c3165d35a24356b45659ccc

[Bence, 2017-05-25 15:10:47]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 15:11:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-05-25 15:46:01]

bnc@chromium.org changed reviewers:
+ zhongyi@chromium.org

[Bence, 2017-05-25 15:46:03]

Zhongyi: PTAL.  Thank you!

https://codereview.chromium.org/2902383002/diff/1/net/http/http_network_trans...
File net/http/http_network_transaction_unittest.cc (left):

https://codereview.chromium.org/2902383002/diff/1/net/http/http_network_trans...
net/http/http_network_transaction_unittest.cc:13850: RuleBasedHostResolverProc*
rules() { return host_resolver_.rules(); }
Remove unused method.

https://codereview.chromium.org/2902383002/diff/1/net/http/http_network_trans...
net/http/http_network_transaction_unittest.cc:13853: int Resolve(const
RequestInfo& info,
Remove method that would trivially call into base class's method.

https://codereview.chromium.org/2902383002/diff/1/net/http/http_network_trans...
net/http/http_network_transaction_unittest.cc:13872: MockCachingHostResolver*
GetMockHostResolver() {
Remove unused method.  This is my favorite part!

https://codereview.chromium.org/2902383002/diff/1/net/http/http_network_trans...
File net/http/http_network_transaction_unittest.cc (right):

https://codereview.chromium.org/2902383002/diff/1/net/http/http_network_trans...
net/http/http_network_transaction_unittest.cc:13844: class
OneTimeCachingHostResolver : public MockHostResolverBase {
Make this class inherit from MockHostResolverBase so that it can be shoved into
session_deps_.host_resolver.  The other option would be, as originally done, to
put it into params.host_resolver, for which a HostResolver suffices, however, in
that case, everything would need to be copied over from
SpdySessionDependencies::SpdyCreateSessionWithSocketFactory(), which would be
fragile due to code duplication.

[commit-bot: I haz the power, 2017-05-25 17:34:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 17:34:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zhongyi Shi, 2017-05-25 20:00:17]

The CQ bit was checked by zhongyi@chromium.org

[Zhongyi Shi, 2017-05-25 20:00:18]

lgtm

Thanks for the clean up!

[commit-bot: I haz the power, 2017-05-25 20:01:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 20:11:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495742417936490, "parent_rev":
"38ca4d86dba6022a465b9966e6917a9e004e919b", "commit_rev":
"6dcd8194cc47b97f5c3165d35a24356b45659ccc"}

[commit-bot: I haz the power, 2017-05-25 20:12:09]

Description was changed from

==========
Fix HttpNetworkTransactionTest.UseIPConnectionPoolingWithHostCacheExpiration.

BUG=726027
==========

to

==========
Fix HttpNetworkTransactionTest.UseIPConnectionPoolingWithHostCacheExpiration.

BUG=726027

Review-Url: https://codereview.chromium.org/2902383002
Cr-Commit-Position: refs/heads/master@{#474773}
Committed:
https://chromium.googlesource.com/chromium/src/+/6dcd8194cc47b97f5c3165d35a24...
==========

[commit-bot: I haz the power, 2017-05-25 20:12:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6dcd8194cc47b97f5c3165d35a24...