Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2902373002: Add Login.PromptToLoginTime UMA metric (Closed)

Created:
3 years, 7 months ago by Yusuke Sato
Modified:
3 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Login.PromptToLoginTime UMA metric This is similar to Login.PromptToCompleteLoginTime, but for existing users. BUG=726345 TEST=manually confirmed that the path is taken when an existing user signs into Chrome OS Review-Url: https://codereview.chromium.org/2902373002 Cr-Commit-Position: refs/heads/master@{#474885} Committed: https://chromium.googlesource.com/chromium/src/+/5f7fd11473c746726e2e1917680a34acde058f19

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Yusuke Sato
Please take a look.
3 years, 6 months ago (2017-05-25 15:23:38 UTC) #6
afakhry
I'm not the owner of either files, so I'm going to delegate to alemate@
3 years, 6 months ago (2017-05-25 16:00:39 UTC) #9
Yusuke Sato
Thanks Ahmed. +isherman@ for the xml file too. Please have a look.
3 years, 6 months ago (2017-05-25 21:08:51 UTC) #11
Ilya Sherman
Metrics LGTM, thanks.
3 years, 6 months ago (2017-05-25 22:04:41 UTC) #12
Alexander Alekseev
lgtm
3 years, 6 months ago (2017-05-26 01:54:29 UTC) #13
Yusuke Sato
thanks!
3 years, 6 months ago (2017-05-26 02:35:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902373002/1
3 years, 6 months ago (2017-05-26 02:37:01 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 02:42:23 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5f7fd11473c746726e2e1917680a...

Powered by Google App Engine
This is Rietveld 408576698