Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2902353002:
Fix "Generate Orderfile failing on internal.client.clank/orderfile-clankium" (Closed)
DescriptionFix "Generate Orderfile failing on internal.client.clank/orderfile-clankium"
Error: The vtable symbol may be undefined because the class is missing its key function
(see go/missingkeymethod)
BUG=726043
TBR=groby@chromium.org
Review-Url: https://codereview.chromium.org/2902353002
Cr-Commit-Position: refs/heads/master@{#474556}
Committed: https://chromium.googlesource.com/chromium/src/+/23aebb59595b4be9d0ec2d9272cf3c596dd9f2bd
Patch Set 1 #Patch Set 2 : format #
Total comments: 1
Messages
Total messages: 21 (12 generated)
Description was changed from ========== Fix "Generate Orderfile failing on internal.client.clank/orderfile-clankium" Error: The vtable symbol may be undefined because the class is missing its key function (see go/missingkeymethod) BUG=726043 ========== to ========== Fix "Generate Orderfile failing on internal.client.clank/orderfile-clankium" Error: The vtable symbol may be undefined because the class is missing its key function (see go/missingkeymethod) BUG=726043 ==========
googleo@chromium.org changed reviewers: + dominickn@chromium.org, napper@chromium.org, wychen@chromium.org
Thanks for your help. This fix should fix the error happened on generating Orderfile.
https://codereview.chromium.org/2902353002/diff/20001/components/translate/co... File components/translate/core/browser/translate_infobar_delegate.h (right): https://codereview.chromium.org/2902353002/diff/20001/components/translate/co... components/translate/core/browser/translate_infobar_delegate.h:47: virtual bool IsDeclinedByUser() = 0; Seems like IsDeclinedByUser() should be a const method.
lgtm. Verified locally.
Description was changed from ========== Fix "Generate Orderfile failing on internal.client.clank/orderfile-clankium" Error: The vtable symbol may be undefined because the class is missing its key function (see go/missingkeymethod) BUG=726043 ========== to ========== Fix "Generate Orderfile failing on internal.client.clank/orderfile-clankium" Error: The vtable symbol may be undefined because the class is missing its key function (see go/missingkeymethod) BUG=726043 TBR=groby@chromium.org ==========
lgtm. Might be safer to not change the const-ness of the method in this CL since the intention is to fix one of the internal waterfalls?
googleo@chromium.org changed reviewers: + groby@chromium.org
groby@chromium.org: Please review changes for a hot fix
The CQ bit was checked by googleo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks all, since it failed internal build. I jut keep it as simple as possible. Submit it after passing all checks.
The CQ bit was unchecked by googleo@chromium.org
The CQ bit was checked by googleo@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by googleo@chromium.org
The CQ bit was checked by googleo@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495682572306040,
"parent_rev": "035b78d057539f9542f9962411108fce5e2085ba", "commit_rev":
"23aebb59595b4be9d0ec2d9272cf3c596dd9f2bd"}
Message was sent while issue was closed.
Description was changed from ========== Fix "Generate Orderfile failing on internal.client.clank/orderfile-clankium" Error: The vtable symbol may be undefined because the class is missing its key function (see go/missingkeymethod) BUG=726043 TBR=groby@chromium.org ========== to ========== Fix "Generate Orderfile failing on internal.client.clank/orderfile-clankium" Error: The vtable symbol may be undefined because the class is missing its key function (see go/missingkeymethod) BUG=726043 TBR=groby@chromium.org Review-Url: https://codereview.chromium.org/2902353002 Cr-Commit-Position: refs/heads/master@{#474556} Committed: https://chromium.googlesource.com/chromium/src/+/23aebb59595b4be9d0ec2d9272cf... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/23aebb59595b4be9d0ec2d9272cf... |
