Chromium Code Reviews
DescriptionRevert of memory-infra: LOG(FATAL) on unsupported heap profiler configs (patchset #3 id:40001 of https://codereview.chromium.org/2903733003/ )
Reason for revert:
As noted in my comment on Patch Set #3, this disables heap-profiling on Windows, even in Static builds.
Original issue's description:
> memory-infra: LOG(FATAL) on unsupported heap profiler configs
>
> Adds a fatal error when trying to use the heap profiler in a
> configuration where it cannot work (e.g., Win debug or component
> builds, or anything that doesn't have the shim)
>
> BUG=705461
>
> Review-Url: https://codereview.chromium.org/2903733003
> Cr-Commit-Position: refs/heads/master@{#474468}
> Committed: https://chromium.googlesource.com/chromium/src/+/59c3060ac761de2221eea6febe7be5d223f0266a
TBR=erikchen@chromium.org,primiano@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=705461
Review-Url: https://codereview.chromium.org/2902343002
Cr-Commit-Position: refs/heads/master@{#474501}
Committed: https://chromium.googlesource.com/chromium/src/+/e568d4d0e6a2039808505a21ea37c8cecbc32fe3
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||