Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2902343002: Revert of memory-infra: LOG(FATAL) on unsupported heap profiler configs (Closed)

Created:
3 years, 7 months ago by Wez
Modified:
3 years, 7 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of memory-infra: LOG(FATAL) on unsupported heap profiler configs (patchset #3 id:40001 of https://codereview.chromium.org/2903733003/ ) Reason for revert: As noted in my comment on Patch Set #3, this disables heap-profiling on Windows, even in Static builds. Original issue's description: > memory-infra: LOG(FATAL) on unsupported heap profiler configs > > Adds a fatal error when trying to use the heap profiler in a > configuration where it cannot work (e.g., Win debug or component > builds, or anything that doesn't have the shim) > > BUG=705461 > > Review-Url: https://codereview.chromium.org/2903733003 > Cr-Commit-Position: refs/heads/master@{#474468} > Committed: https://chromium.googlesource.com/chromium/src/+/59c3060ac761de2221eea6febe7be5d223f0266a TBR=erikchen@chromium.org,primiano@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=705461 Review-Url: https://codereview.chromium.org/2902343002 Cr-Commit-Position: refs/heads/master@{#474501} Committed: https://chromium.googlesource.com/chromium/src/+/e568d4d0e6a2039808505a21ea37c8cecbc32fe3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M base/trace_event/memory_dump_manager.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Wez
Created Revert of memory-infra: LOG(FATAL) on unsupported heap profiler configs
3 years, 7 months ago (2017-05-25 00:49:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2902343002/1
3 years, 7 months ago (2017-05-25 00:50:02 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 00:51:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e568d4d0e6a2039808505a21ea37...

Powered by Google App Engine
This is Rietveld 408576698