Milo: Swarming module test coverage

milo/appengine/swarming/buildinfo_test.go

Index: milo/appengine/swarming/buildinfo_test.go
diff --git a/milo/appengine/swarming/buildinfo_test.go b/milo/appengine/swarming/buildinfo_test.go
index 3ac757fd923871350c8584fe82d8a15c0d9292b8..57f1d7ca43d0c8a82f1907e5cdadf99e6137a069 100644
--- a/milo/appengine/swarming/buildinfo_test.go
+++ b/milo/appengine/swarming/buildinfo_test.go
@@ -10,6 +10,7 @@ import (
 
 	swarming "github.com/luci/luci-go/common/api/swarming/swarming/v1"
 	miloProto "github.com/luci/luci-go/common/proto/milo"
+	"github.com/luci/luci-go/grpc/grpcutil"
 	"github.com/luci/luci-go/logdog/api/endpoints/coordinator/logs/v1"
 	"github.com/luci/luci-go/logdog/client/coordinator"
 	milo "github.com/luci/luci-go/milo/api/proto"
@@ -28,6 +29,7 @@ type testSwarmingService struct {
 	host string
 	req  swarming.SwarmingRpcsTaskRequest
 	res  swarming.SwarmingRpcsTaskResult
+	out  string
 }
 
 func (sf *testSwarmingService) getHost() string { return sf.host }
@@ -44,6 +46,10 @@ func (sf *testSwarmingService) getSwarmingRequest(c context.Context, taskID stri
 	return &sf.req, nil
 }
 
+func (sf *testSwarmingService) getTaskOutput(c context.Context, taskID string) (string, error) {
+	return sf.out, nil
+}
+
 func TestBuildInfo(t *testing.T) {
 	t.Parallel()
 
@@ -192,6 +198,13 @@ func TestBuildInfo(t *testing.T) {
 					Name:   "annotations",
 				},
 			})
+
+			Convey("Will return NotFound if the build is internal", func() {
+				testSvc.res.Tags = testSvc.res.Tags[1:]
+				testSvc.req.Tags = testSvc.req.Tags[1:]

[nodir, 2017/06/08 14:39:12]

undup line or testSvc.req.Tags = testSvc.req.Tags[2:]

+				_, err := bip.GetBuildInfo(c, biReq.GetSwarming(), "testproject")
+				So(err, ShouldResemble, grpcutil.NotFound)
+			})
 		})
 	})
 }