Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2902313002:
[MD settings] show controlledBy icon for HostApp and platform_app exceptions (Closed)
|
Created:
3 years, 7 months ago by dschuyler Modified:
3 years, 7 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] show controlledBy icon for HostApp and platform_app exceptions
This CL will show content settings exceptions as |enforced| if their
source is 'HostedApp' or 'platform_app' (in addition to the previous enforced
sources of 'policy' and 'extension'.
BUG=724940
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2902313002
Cr-Commit-Position: refs/heads/master@{#474752}
Committed: https://chromium.googlesource.com/chromium/src/+/13157f21a3e66cad40850e65c741795144817f2f
Patch Set 1 #
Total comments: 2
Patch Set 2 : added braces #Messages
Total messages: 17 (12 generated)
Description was changed from ========== [MD settings] show controlledBy icon for HostApp and platform_app exceptions This CL will show content settings exceptions as |enforced| if their source is 'HostedApp' or 'platform_app' (in addition to the previous enforced sources of 'policy' and 'extension'. BUG=724940 ========== to ========== [MD settings] show controlledBy icon for HostApp and platform_app exceptions This CL will show content settings exceptions as |enforced| if their source is 'HostedApp' or 'platform_app' (in addition to the previous enforced sources of 'policy' and 'extension'. BUG=724940 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
lgtm but is there like a list or enum of potential sources somewhere we could use instead of duplicating these string literals? https://codereview.chromium.org/2902313002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/site_settings/site_settings_behavior.js (right): https://codereview.chromium.org/2902313002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/site_settings/site_settings_behavior.js:172: exception.source == 'platform_app' || exception.source == 'policy') nit: curlies
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/25 00:17:01, Dan Beam wrote: > lgtm but is there like a list or enum of potential sources somewhere we could > use instead of duplicating these string literals? I'd like that. I made a crbug to follow-up Issue 726168 > > https://codereview.chromium.org/2902313002/diff/1/chrome/browser/resources/se... > File chrome/browser/resources/settings/site_settings/site_settings_behavior.js > (right): > > https://codereview.chromium.org/2902313002/diff/1/chrome/browser/resources/se... > chrome/browser/resources/settings/site_settings/site_settings_behavior.js:172: > exception.source == 'platform_app' || exception.source == 'policy') > nit: curlies
https://codereview.chromium.org/2902313002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/site_settings/site_settings_behavior.js (right): https://codereview.chromium.org/2902313002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/site_settings/site_settings_behavior.js:172: exception.source == 'platform_app' || exception.source == 'policy') On 2017/05/25 00:17:01, Dan Beam wrote: > nit: curlies Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by dschuyler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2902313002/#ps20001 (title: "added braces")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495736897329000,
"parent_rev": "4a21fd7fbad35d3105789fddd733b5e9a723ffaa", "commit_rev":
"13157f21a3e66cad40850e65c741795144817f2f"}
Message was sent while issue was closed.
Description was changed from ========== [MD settings] show controlledBy icon for HostApp and platform_app exceptions This CL will show content settings exceptions as |enforced| if their source is 'HostedApp' or 'platform_app' (in addition to the previous enforced sources of 'policy' and 'extension'. BUG=724940 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] show controlledBy icon for HostApp and platform_app exceptions This CL will show content settings exceptions as |enforced| if their source is 'HostedApp' or 'platform_app' (in addition to the previous enforced sources of 'policy' and 'extension'. BUG=724940 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2902313002 Cr-Commit-Position: refs/heads/master@{#474752} Committed: https://chromium.googlesource.com/chromium/src/+/13157f21a3e66cad40850e65c741... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/13157f21a3e66cad40850e65c741... |
