third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js - Issue 2902273002: DevTools: convert linkifyURL params into options object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

Issue 2902273002: DevTools: convert linkifyURL params into options object (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/components/Linkifier.js ('K') | « third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

index 87cfc3789a332c8af263187909cecee5b000a910..957a9aee8e0817db99fd7d44572d007fb7687b34 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js

@@ -1276,7 +1276,7 @@ Elements.ElementsTreeElement = class extends UI.TreeElement {

value = value.trimMiddle(60);

var link = node.nodeName().toLowerCase() === 'a' ?

UI.createExternalLink(rewrittenHref, value, '', true) :

- Components.Linkifier.linkifyURL(rewrittenHref, value, '', undefined, undefined, true);

+ Components.Linkifier.linkifyURL({url: rewrittenHref, text: value, preventClick: true});

link[Elements.ElementsTreeElement.HrefSymbol] = rewrittenHref;

return link;

}